Skip to content

Commit 27ada02

Browse files
committed
Revert "Expose property to configure OAuth2 provider configurationMetadata"
This reverts commit 7b79029. See gh-21375
1 parent daed512 commit 27ada02

File tree

4 files changed

+0
-26
lines changed

4 files changed

+0
-26
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2ClientProperties.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.springframework.boot.autoconfigure.security.oauth2.client;
1818

1919
import java.util.HashMap;
20-
import java.util.LinkedHashMap;
2120
import java.util.Map;
2221
import java.util.Set;
2322

@@ -220,11 +219,6 @@ public static class Provider {
220219
*/
221220
private String issuerUri;
222221

223-
/**
224-
* Additional metadata describing the provider's configuration.
225-
*/
226-
private Map<String, Object> configurationMetadata = new LinkedHashMap<>();
227-
228222
public String getAuthorizationUri() {
229223
return this.authorizationUri;
230224
}
@@ -281,10 +275,6 @@ public void setIssuerUri(String issuerUri) {
281275
this.issuerUri = issuerUri;
282276
}
283277

284-
public Map<String, Object> getConfigurationMetadata() {
285-
return this.configurationMetadata;
286-
}
287-
288278
}
289279

290280
}

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2ClientPropertiesRegistrationAdapter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ private static Builder getBuilder(Builder builder, Provider provider) {
116116
.to(builder::userInfoAuthenticationMethod);
117117
map.from(provider::getJwkSetUri).to(builder::jwkSetUri);
118118
map.from(provider::getUserNameAttribute).to(builder::userNameAttributeName);
119-
map.from(provider::getConfigurationMetadata).to(builder::providerConfigurationMetadata);
120119
return builder;
121120
}
122121

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2ClientPropertiesRegistrationAdapterTests.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -238,20 +238,6 @@ void issuerUriConfigurationTriesOAuthMetadataUriThird() throws Exception {
238238
testIssuerConfiguration(login, "okta", 2, 3);
239239
}
240240

241-
@Test
242-
void configurationMetadataFromProviderIsAdapted() {
243-
Provider provider = createProvider();
244-
provider.getConfigurationMetadata().put("end_session_endpoint", "https://myendsessionendpoint");
245-
OAuth2ClientProperties.Registration registration = createRegistration("my-oauth-provider");
246-
OAuth2ClientProperties properties = new OAuth2ClientProperties();
247-
properties.getRegistration().put("registration", registration);
248-
properties.getProvider().put("my-oauth-provider", provider);
249-
Map<String, ClientRegistration> registrations = OAuth2ClientPropertiesRegistrationAdapter
250-
.getClientRegistrations(properties);
251-
assertThat(registrations.get("registration").getProviderDetails().getConfigurationMetadata()
252-
.get("end_session_endpoint")).isEqualTo("https://myendsessionendpoint");
253-
}
254-
255241
@Test
256242
void oidcProviderConfigurationWithCustomConfigurationOverridesProviderDefaults() throws Exception {
257243
this.server = new MockWebServer();

spring-boot-project/spring-boot-docs/src/main/asciidoc/spring-boot-features.adoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3219,7 +3219,6 @@ You can register multiple OAuth2 clients and providers under the `spring.securit
32193219
spring.security.oauth2.client.provider.my-oauth-provider.user-info-authentication-method=header
32203220
spring.security.oauth2.client.provider.my-oauth-provider.jwk-set-uri=https://my-auth-server/token_keys
32213221
spring.security.oauth2.client.provider.my-oauth-provider.user-name-attribute=name
3222-
spring.security.oauth2.client.provider.my-oauth-provider.configuration-metadata.end_session_endpoint=https://my-end-session-endpoint
32233222
----
32243223

32253224
For OpenID Connect providers that support https://openid.net/specs/openid-connect-discovery-1_0.html[OpenID Connect discovery], the configuration can be further simplified.

0 commit comments

Comments
 (0)