Checkstyle fixes in spring-ai-commons

Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>

Author: sobychacko

spring-ai-commons/src/main/java/org/springframework/ai/document/Document.java

@@ -25,9 +25,9 @@
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonProperty;
 
+import org.springframework.ai.content.Media;
 import org.springframework.ai.document.id.IdGenerator;
 import org.springframework.ai.document.id.RandomIdGenerator;
-import org.springframework.ai.content.Media;
 import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
 import org.springframework.util.StringUtils;

spring-ai-commons/src/main/java/org/springframework/ai/embedding/BatchingStrategy.java

@@ -30,13 +30,13 @@
 public interface BatchingStrategy {
 
 	/**
-	 * {@link EmbeddingModel} implementations can call this method to optimize embedding
-	 * tokens. The incoming collection of {@link Document}s are split into sub-batches. It
-	 * is important to preserve the order of the list of {@link Document}s when batching
-	 * as they are mapped to their corresponding embeddings by their order.
+	 * EmbeddingModel implementations can call this method to optimize embedding tokens.
+	 * The incoming collection of {@link Document}s are split into sub-batches. It is
+	 * important to preserve the order of the list of {@link Document}s when batching as
+	 * they are mapped to their corresponding embeddings by their order.
 	 * @param documents to batch
 	 * @return a list of sub-batches that contain {@link Document}s.
 	 */
 	List<List<Document>> batch(List<Document> documents);
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/embedding/TokenCountBatchingStrategy.java

@@ -169,4 +169,4 @@ public List<List<Document>> batch(List<Document> documents) {
 		return batches;
 	}
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/AiObservationAttributes.java

@@ -151,4 +151,4 @@ public String value() {
 
 // @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/AiObservationEventNames.java

@@ -56,4 +56,4 @@ public String value() {
 
 // @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/AiObservationMetricAttributes.java

@@ -51,4 +51,4 @@ public String value() {
 
 // @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/AiObservationMetricNames.java

@@ -52,4 +52,4 @@ public String value() {
 		return this.value;
 	}
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/AiOperationType.java

@@ -72,4 +72,4 @@ public String value() {
 
 	// @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/AiProvider.java

@@ -117,4 +117,4 @@ public String value() {
 
 	// @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/AiTokenType.java

@@ -59,4 +59,4 @@ public String value() {
 
 // @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/SpringAiKind.java

@@ -58,4 +58,4 @@ public String value() {
 
 	// @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/VectorStoreObservationAttributes.java

@@ -119,4 +119,4 @@ public String value() {
 
 // @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/VectorStoreObservationEventNames.java

@@ -47,4 +47,4 @@ public String value() {
 
 // @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/VectorStoreProvider.java

@@ -151,4 +151,4 @@ public String value() {
 		return this.value;
 	}
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/VectorStoreSimilarityMetric.java

@@ -63,4 +63,4 @@ public String value() {
 
 	// @formatter:on
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/observation/conventions/package-info.java

@@ -22,4 +22,4 @@
 package org.springframework.ai.observation.conventions;
 
 import org.springframework.lang.NonNullApi;
-import org.springframework.lang.NonNullFields;
+import org.springframework.lang.NonNullFields;

spring-ai-commons/src/main/java/org/springframework/ai/observation/package-info.java

@@ -17,4 +17,4 @@
 /**
  * Core observation abstractions.
  */
-package org.springframework.ai.observation;
+package org.springframework.ai.observation;

spring-ai-commons/src/main/java/org/springframework/ai/observation/tracing/TracingHelper.java

@@ -78,4 +78,4 @@ public static String concatenateStrings(List<String> strings) {
 		return stringsJoiner.toString();
 	}
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/util/JacksonUtils.java

@@ -88,4 +88,4 @@ public static List<Module> instantiateAvailableModules() {
 		return modules;
 	}
 
-}
+}

spring-ai-commons/src/main/java/org/springframework/ai/util/LoggingMarkers.java

@@ -26,7 +26,7 @@
  *
  * @author Konstantin Pavlov
  */
-public class LoggingMarkers {
+public final class LoggingMarkers {
 
 	/**
 	 * Marker used to identify log statements associated with <strong>sensitive
@@ -84,4 +84,8 @@ public class LoggingMarkers {
 	 */
 	public static final Marker PUBLIC_DATA_MARKER = MarkerFactory.getMarker("PUBLIC");
 
+	private LoggingMarkers() {
+		// private constructor to avoid instantiation
+	}
+
 }

spring-ai-commons/src/test/java/org/springframework/ai/document/DocumentBuilderTests.java

@@ -24,8 +24,8 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-import org.springframework.ai.document.id.IdGenerator;
 import org.springframework.ai.content.Media;
+import org.springframework.ai.document.id.IdGenerator;
 import org.springframework.util.MimeTypeUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;

spring-ai-commons/src/test/java/org/springframework/ai/document/DocumentTests.java

@@ -23,8 +23,8 @@
 
 import org.junit.jupiter.api.Test;
 
-import org.springframework.ai.document.id.IdGenerator;
 import org.springframework.ai.content.Media;
+import org.springframework.ai.document.id.IdGenerator;
 import org.springframework.util.MimeTypeUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;

spring-ai-commons/src/test/java/org/springframework/ai/embedding/TokenCountBatchingStrategyTests.java

@@ -54,4 +54,4 @@ void batchEmbeddingWithLargeDocumentExceedsMaxTokenSize() throws IOException {
 			.isInstanceOf(IllegalArgumentException.class);
 	}
 
-}
+}

spring-ai-commons/src/test/java/org/springframework/ai/observation/AiOperationMetadataTests.java

@@ -63,4 +63,4 @@ void whenProviderIsEmptyThenThrow() {
 			.hasMessageContaining("provider cannot be null or empty");
 	}
 
-}
+}

spring-ai-commons/src/test/java/org/springframework/ai/observation/tracing/TracingHelperTests.java

@@ -140,4 +140,4 @@ public Span remoteIpAndPort(String s, int i) {
 
 	}
 
-}
+}

spring-ai-commons/src/test/java/org/springframework/ai/transformer/splitter/TokenTextSplitterTest.java

@@ -23,7 +23,6 @@
 
 import org.springframework.ai.document.DefaultContentFormatter;
 import org.springframework.ai.document.Document;
-import org.springframework.ai.transformer.splitter.TokenTextSplitter;
 
 import static org.assertj.core.api.Assertions.assertThat;