Merge pull request #205 from splitio/dw

PHP 7.1.7

Author: mmelograno

CHANGES.txt

@@ -1,3 +1,7 @@
+7.1.7 (May 16, 2023)
+ - Updated terminology on the SDKs codebase to be more aligned with current standard without causing a breaking change. The core change is the term split for feature flag on things like logs and phpdoc comments.
+ - Fixed php 8.2 warnings in code.
+
 7.1.6 (Feb 14, 2023)
  - Fixed logging on array conversion.
 
@@ -41,7 +45,7 @@
  - Added flag `IPAddressesEnabled` into options to enable/disable sending MachineName and MachineIP when data is posted in headers.
 
 6.2.2 (Sep 18, 2019)
- - Fetch multiple splits at once on getTreatments/getTreatmentsWithConfig
+ - Fetch multiple feature flags at once on getTreatments/getTreatmentsWithConfig
  - Removed MatcherClient (DependencyMatcher now uses Evaluator directly)
  - Removed shared memory.
  - Several code cleanups
@@ -52,7 +56,7 @@
 
 6.2.0 (May 30, 2019)
  - Added validation for TrafficType in track calls.
- - Added validation when split does not exist on treatments and manager calls.
+ - Added validation when feature flag does not exist on treatments and manager calls.
  - Added multiple factory instantiation check.
  - Removed producer modules.
  - Added properties to track method.
@@ -94,7 +98,7 @@
  - Downgrade logging level for shared memory messages
 
 5.2.3: (Sep 5, 2017)
- - Adding hotfix to return empty splits array in SplitManager when redis is empty.
+ - Adding hotfix to return empty feature flags array in SplitManager when redis is empty.
 
 5.2.2: (Aug 1, 2017)
  - Adding hotfix to return CONTROL if redis is down instead of failing.

LICENSE

@@ -1,4 +1,4 @@
-Copyright © 2022 Split Software, Inc.
+Copyright © 2023 Split Software, Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

README.md

@@ -4,23 +4,24 @@
 [![Latest stable](https://img.shields.io/packagist/v/splitsoftware/split-sdk-php)](https://packagist.org/packages/splitsoftware/split-sdk-php)
 [![Documentation](https://img.shields.io/badge/php_client-documentation-informational)](https://help.split.io/hc/en-us/articles/360020350372-PHP-SDK)
 
-This SDK is designed to work with Split, the platform for controlled rollouts, serving features to your users via the Split feature flag to manage your complete customer experience.
+## Overview
+This SDK is designed to work with Split, the platform for controlled rollouts, which serves features to your users via feature flags to manage your complete customer experience.
 
 ## Compatibility
 This SDK is compatible with PHP 7.3 and above.
 
 ## Getting started
 Below is a simple example that describes the instantiation and most basic usage of our SDK.
-Keep in mind that since PHP does not have the ability to share memory between processes the use of the [split-synchronizer](https://help.split.io/hc/en-us/articles/360019686092-Split-Synchronizer-Proxy) is mandatory for this SDK.
+Keep in mind that since PHP does not have the ability to share memory between processes the use of the [split-synchronizer](https://help.split.io/hc/en-us/articles/360019686092-Split-Synchronizer) is mandatory for this SDK.
 
 ```php
 <?php
 
 $sdkConfig = ['cache' => ['adapter' => 'predis']];
-$splitFactory = \SplitIO\Sdk::factory('SDK_API_KEY', $sdkConfig);
+$splitFactory = \SplitIO\Sdk::factory('YOUR_SDK_KEY', $sdkConfig);
 
 $splitClient = $splitFactory->client();
-$treatment = $splitClient->getTreatment('CUSTOMER_ID','SPLIT_NAME');
+$treatment = $splitClient->getTreatment('CUSTOMER_ID','FEATURE_FLAG_NAME');
 if ($treatment === 'on') {
     // Feature is enabled for this user!
 } elseif ($treatment === 'off') {
@@ -30,9 +31,11 @@ if ($treatment === 'on') {
 }
 ```
 
+Please refer to [our official docs](https://help.split.io/hc/en-us/articles/360020350372-PHP-SDK) to learn about all the functionality provided by our SDK and the configuration options available for tailoring it to your current application setup.
+
 ## Submitting issues
 
-The Split team monitors all issues submitted to this [issue tracker](https://github.com/splitio/php-client/issues). We encourage you to use this issue tracker to submit any bug reports, feedback, and feature enhancements. We'll do our best to respond in a timely manner.
+ The Split team monitors all issues submitted to this [issue tracker](https://github.com/splitio/php-client/issues). We encourage you to use this issue tracker to submit any bug reports, feedback, and feature enhancements. We'll do our best to respond in a timely manner.
 
 ## Contributing
 Please see [Contributors Guide](CONTRIBUTORS-GUIDE.md) to find all you need to submit a Pull Request (PR).
@@ -48,16 +51,21 @@ To learn more about Split, contact hello@split.io, or get started with feature f
 
 Split has built and maintains SDKs for:
 
+* .NET [Github](https://github.com/splitio/dotnet-client) [Docs](https://help.split.io/hc/en-us/articles/360020240172--NET-SDK)
+* Android [Github](https://github.com/splitio/android-client) [Docs](https://help.split.io/hc/en-us/articles/360020343291-Android-SDK)
+* Angular [Github](https://github.com/splitio/angular-sdk-plugin) [Docs](https://help.split.io/hc/en-us/articles/6495326064397-Angular-utilities)
+* GO [Github](https://github.com/splitio/go-client) [Docs](https://help.split.io/hc/en-us/articles/360020093652-Go-SDK)
+* iOS [Github](https://github.com/splitio/ios-client) [Docs](https://help.split.io/hc/en-us/articles/360020401491-iOS-SDK)
 * Java [Github](https://github.com/splitio/java-client) [Docs](https://help.split.io/hc/en-us/articles/360020405151-Java-SDK)
-* Javascript [Github](https://github.com/splitio/javascript-client) [Docs](https://help.split.io/hc/en-us/articles/360020448791-JavaScript-SDK)
+* JavaScript [Github](https://github.com/splitio/javascript-client) [Docs](https://help.split.io/hc/en-us/articles/360020448791-JavaScript-SDK)
+* JavaScript for Browser [Github](https://github.com/splitio/javascript-browser-client) [Docs](https://help.split.io/hc/en-us/articles/360058730852-Browser-SDK)
 * Node [Github](https://github.com/splitio/javascript-client) [Docs](https://help.split.io/hc/en-us/articles/360020564931-Node-js-SDK)
-* .NET [Github](https://github.com/splitio/dotnet-client) [Docs](https://help.split.io/hc/en-us/articles/360020240172--NET-SDK)
-* Ruby [Github](https://github.com/splitio/ruby-client) [Docs](https://help.split.io/hc/en-us/articles/360020673251-Ruby-SDK)
 * PHP [Github](https://github.com/splitio/php-client) [Docs](https://help.split.io/hc/en-us/articles/360020350372-PHP-SDK)
 * Python [Github](https://github.com/splitio/python-client) [Docs](https://help.split.io/hc/en-us/articles/360020359652-Python-SDK)
-* GO [Github](https://github.com/splitio/go-client) [Docs](https://help.split.io/hc/en-us/articles/360020093652-Go-SDK)
-* Android [Github](https://github.com/splitio/android-client) [Docs](https://help.split.io/hc/en-us/articles/360020343291-Android-SDK)
-* iOS [Github](https://github.com/splitio/ios-client) [Docs](https://help.split.io/hc/en-us/articles/360020401491-iOS-SDK)
+* React [Github](https://github.com/splitio/react-client) [Docs](https://help.split.io/hc/en-us/articles/360038825091-React-SDK)
+* React Native [Github](https://github.com/splitio/react-native-client) [Docs](https://help.split.io/hc/en-us/articles/4406066357901-React-Native-SDK)
+* Redux [Github](https://github.com/splitio/redux-client) [Docs](https://help.split.io/hc/en-us/articles/360038851551-Redux-SDK)
+* Ruby [Github](https://github.com/splitio/ruby-client) [Docs](https://help.split.io/hc/en-us/articles/360020673251-Ruby-SDK)
 
 For a comprehensive list of open source projects visit our [Github page](https://github.com/splitio?utf8=%E2%9C%93&query=%20only%3Apublic%20).
 

src/SplitIO/Component/Cache/SplitCache.php

@@ -59,7 +59,9 @@ public function getSplit($splitName)
     public function getSplits($splitNames)
     {
         $cache = Di::getCache();
-        $cacheItems = $cache->fetchMany(array_map('self::getCacheKeyForSplit', $splitNames));
+        $cacheItems = $cache->fetchMany(array_map([
+            self::class, 'getCacheKeyForSplit'
+        ], $splitNames));
         $toReturn = array();
         foreach ($cacheItems as $key => $value) {
             $toReturn[self::getSplitNameFromCacheKey($key)] = $value;
@@ -74,7 +76,7 @@ public function getSplitNames()
     {
         $cache = Di::getCache();
         $splitKeys = $cache->getKeys(self::getCacheKeySearchPattern());
-        return array_map('self::getSplitNameFromCacheKey', $splitKeys);
+        return array_map([self::class, 'getSplitNameFromCacheKey'], $splitKeys);
     }
 
     /**

src/SplitIO/Grammar/Condition/Matcher/ContainsString.php

@@ -6,7 +6,7 @@
 
 class ContainsString extends AbstractMatcher
 {
-    protected $ContainsStringMatcherData = null;
+    private $containsStringMatcherData = null;
 
     public function __construct($data, $negate = false, $attribute = null)
     {

src/SplitIO/Grammar/Split.php

@@ -51,7 +51,7 @@ public function __construct(array $split)
         $this->configurations = isset($split['configurations']) && count($split['configurations']) > 0 ?
             $split['configurations'] : null;
 
-        SplitApp::logger()->info("Constructing Split: ".$this->name);
+        SplitApp::logger()->info("Constructing Feature Flag: ".$this->name);
 
         if (isset($split['conditions']) && is_array($split['conditions'])) {
             $this->conditions = array();