Skip to content

Commit afb1ae8

Browse files
EmilianoSanchezEmilianoSanchez
committed
Rename some variables in test suite for readability
1 parent b8c0910 commit afb1ae8

File tree

7 files changed

+29
-29
lines changed

7 files changed

+29
-29
lines changed

‎src/__tests__/browserSuites/impressions.debug.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@ export default function (fetchMock, assert) {
7575

7676
fetchMock.postOnce(url(settings, '/testImpressions/count'), (url, opts) => {
7777
assert.deepEqual(JSON.parse(opts.body), {
78-
pf: [{ f: 'always_on_track_impressions_false', m: truncatedTimeFrame, rc: 1 }]
78+
pf: [{ f: 'always_on_impressions_disabled_true', m: truncatedTimeFrame, rc: 1 }]
7979
}, 'We should generate impression count for the feature with track impressions disabled.');
8080

8181
return 200;
8282
});
8383

8484
fetchMock.postOnce(url(settings, '/v1/keys/cs'), (url, opts) => {
8585
assert.deepEqual(JSON.parse(opts.body), {
86-
keys: [{ fs: ['always_on_track_impressions_false'], k: 'facundo@split.io' }]
86+
keys: [{ fs: ['always_on_impressions_disabled_true'], k: 'facundo@split.io' }]
8787
}, 'We should track unique keys for the feature with track impressions disabled.');
8888

8989
return 200;
@@ -95,6 +95,6 @@ export default function (fetchMock, assert) {
9595
client.getTreatment('split_with_config');
9696
client.getTreatment('split_with_config');
9797
client.getTreatment('split_with_config');
98-
assert.equal(client.getTreatment('always_on_track_impressions_false'), 'on');
98+
assert.equal(client.getTreatment('always_on_impressions_disabled_true'), 'on');
9999
});
100100
}

‎src/__tests__/browserSuites/impressions.none.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export default async function (fetchMock, assert) {
5959
{ f: 'split_with_config', m: truncatedTimeFrame, rc: 2 },
6060
{ f: 'always_off', m: truncatedTimeFrame, rc: 4 },
6161
{ f: 'always_on', m: truncatedTimeFrame, rc: 2 },
62-
{ f: 'always_on_track_impressions_false', m: truncatedTimeFrame, rc: 1 }
62+
{ f: 'always_on_impressions_disabled_true', m: truncatedTimeFrame, rc: 1 }
6363
]
6464
});
6565
return 200;
@@ -76,7 +76,7 @@ export default async function (fetchMock, assert) {
7676
},
7777
{
7878
k: 'emma@split.io',
79-
fs: ['always_off', 'always_on', 'always_on_track_impressions_false']
79+
fs: ['always_off', 'always_on', 'always_on_impressions_disabled_true']
8080
}
8181
]
8282
}, 'We performed evaluations for two keys, so we should have 2 item total.');
@@ -94,7 +94,7 @@ export default async function (fetchMock, assert) {
9494
client.getTreatment('always_on');
9595
client.getTreatment('always_off');
9696
client.getTreatment('split_with_config');
97-
sharedClient.getTreatment('always_on_track_impressions_false');
97+
sharedClient.getTreatment('always_on_impressions_disabled_true');
9898

9999
client.destroy().then(() => {
100100
assert.end();

‎src/__tests__/browserSuites/impressions.spec.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ export default function (fetchMock, assert) {
5353

5454
const dependencyChildImpr = resp.filter(e => e.f === 'hierarchical_splits_test')[0];
5555
const splitWithConfigImpr = resp.filter(e => e.f === 'split_with_config')[0];
56-
const alwaysOnWithTrackImpressionsFalse = resp.filter(e => e.f === 'always_on_track_impressions_false');
56+
const alwaysOnWithImpressionsDisabledTrue = resp.filter(e => e.f === 'always_on_impressions_disabled_true');
5757

5858
assert.true(dependencyChildImpr, 'Split we wanted to evaluate should be present on the impressions.');
5959
assert.false(resp.some(e => e.f === 'hierarchical_dep_always_on'), 'Parent split evaluations should not result in impressions.');
6060
assert.false(resp.some(e => e.f === 'hierarchical_dep_hierarchical'), 'No matter how deep is the chain.');
6161
assert.true(splitWithConfigImpr, 'Split evaluated with config should have generated an impression too.');
6262
assert.false(Object.prototype.hasOwnProperty.call(splitWithConfigImpr.i[0], 'configuration'), 'Impressions do not change with configuration evaluations.');
6363
assert.false(Object.prototype.hasOwnProperty.call(splitWithConfigImpr.i[0], 'config'), 'Impressions do not change with configuration evaluations.');
64-
assert.equal(alwaysOnWithTrackImpressionsFalse.length, 0);
64+
assert.equal(alwaysOnWithImpressionsDisabledTrue.length, 0);
6565

6666
const {
6767
k,
@@ -100,21 +100,21 @@ export default function (fetchMock, assert) {
100100

101101
// finding these validate the feature names collection too
102102
const splitWithConfigImpr = data.pf.filter(e => e.f === 'split_with_config')[0];
103-
const alwaysOnWithTrackImpressionsFalse = data.pf.filter(e => e.f === 'always_on_track_impressions_false')[0];
103+
const alwaysOnWithImpressionsDisabledTrue = data.pf.filter(e => e.f === 'always_on_impressions_disabled_true')[0];
104104

105105
assert.equal(splitWithConfigImpr.rc, 2);
106106
assert.equal(typeof splitWithConfigImpr.m, 'number');
107107
assert.equal(splitWithConfigImpr.m, truncatedTimeFrame);
108-
assert.equal(alwaysOnWithTrackImpressionsFalse.rc, 1);
109-
assert.equal(typeof alwaysOnWithTrackImpressionsFalse.m, 'number');
110-
assert.equal(alwaysOnWithTrackImpressionsFalse.m, truncatedTimeFrame);
108+
assert.equal(alwaysOnWithImpressionsDisabledTrue.rc, 1);
109+
assert.equal(typeof alwaysOnWithImpressionsDisabledTrue.m, 'number');
110+
assert.equal(alwaysOnWithImpressionsDisabledTrue.m, truncatedTimeFrame);
111111

112112
return 200;
113113
});
114114

115115
fetchMock.postOnce(url(settings, '/v1/keys/cs'), (url, opts) => {
116116
assert.deepEqual(JSON.parse(opts.body), {
117-
keys: [{ fs: [ 'always_on_track_impressions_false' ], k: 'facundo@split.io' }]
117+
keys: [{ fs: [ 'always_on_impressions_disabled_true' ], k: 'facundo@split.io' }]
118118
}, 'We should only track unique keys for features flags with track impressions disabled.');
119119

120120
return 200;
@@ -132,6 +132,6 @@ export default function (fetchMock, assert) {
132132
client.getTreatmentWithConfig('split_with_config');
133133

134134
// Impression should not be tracked
135-
assert.equal(client.getTreatment('always_on_track_impressions_false'), 'on');
135+
assert.equal(client.getTreatment('always_on_impressions_disabled_true'), 'on');
136136
});
137137
}

‎src/__tests__/mocks/splitchanges.since.-1.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1387,7 +1387,7 @@
13871387
"environment": null,
13881388
"trafficTypeId": null,
13891389
"trafficTypeName": null,
1390-
"name": "always_on_track_impressions_false",
1390+
"name": "always_on_impressions_disabled_true",
13911391
"impressionsDisabled": true,
13921392
"seed": -790401604,
13931393
"status": "ACTIVE",

‎src/__tests__/nodeSuites/impressions.debug.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@ export default async function (key, fetchMock, assert) {
7575

7676
fetchMock.postOnce(url(settings, '/testImpressions/count'), (url, opts) => {
7777
assert.deepEqual(JSON.parse(opts.body), {
78-
pf: [{ f: 'always_on_track_impressions_false', m: truncatedTimeFrame, rc: 1 }]
78+
pf: [{ f: 'always_on_impressions_disabled_true', m: truncatedTimeFrame, rc: 1 }]
7979
}, 'We should generate impression count for the feature with track impressions disabled.');
8080

8181
return 200;
8282
});
8383

8484
fetchMock.postOnce(url(settings, '/v1/keys/ss'), (url, opts) => {
8585
assert.deepEqual(JSON.parse(opts.body), {
86-
keys: [{ f: 'always_on_track_impressions_false', ks: ['other_key'] }]
86+
keys: [{ f: 'always_on_impressions_disabled_true', ks: ['other_key'] }]
8787
}, 'We should track unique keys for the feature with track impressions disabled.');
8888

8989
return 200;
@@ -97,5 +97,5 @@ export default async function (key, fetchMock, assert) {
9797
assert.equal(client.getTreatment({ matchingKey: key, bucketingKey: 'test_buck_key' }, 'split_with_config'), 'o.n');
9898
assert.equal(client.getTreatment({ matchingKey: key, bucketingKey: 'test_buck_key' }, 'split_with_config'), 'o.n');
9999
assert.equal(client.getTreatment({ matchingKey: key, bucketingKey: 'test_buck_key' }, 'split_with_config'), 'o.n');
100-
assert.equal(client.getTreatment({ matchingKey: 'other_key', bucketingKey: 'test_buck_key' }, 'always_on_track_impressions_false'), 'on');
100+
assert.equal(client.getTreatment({ matchingKey: 'other_key', bucketingKey: 'test_buck_key' }, 'always_on_impressions_disabled_true'), 'on');
101101
}

‎src/__tests__/nodeSuites/impressions.none.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export default async function (key, fetchMock, assert) {
5555
{ f: 'split_with_config', m: truncatedTimeFrame, rc: 3 },
5656
{ f: 'always_off', m: truncatedTimeFrame, rc: 3 },
5757
{ f: 'always_on', m: truncatedTimeFrame, rc: 5 },
58-
{ f: 'always_on_track_impressions_false', m: truncatedTimeFrame, rc: 1 }
58+
{ f: 'always_on_impressions_disabled_true', m: truncatedTimeFrame, rc: 1 }
5959
]
6060
});
6161
return 200;
@@ -79,7 +79,7 @@ export default async function (key, fetchMock, assert) {
7979
ks: ['emma@split.io', 'emi@split.io', 'nico@split.io']
8080
},
8181
{
82-
f: 'always_on_track_impressions_false',
82+
f: 'always_on_impressions_disabled_true',
8383
ks: ['emi@split.io']
8484
}
8585
]
@@ -100,7 +100,7 @@ export default async function (key, fetchMock, assert) {
100100
client.getTreatment('nico@split.io', 'always_on');
101101
client.getTreatment('emi@split.io', 'split_with_config');
102102
client.getTreatment('emma@split.io', 'split_with_config');
103-
client.getTreatment('emi@split.io', 'always_on_track_impressions_false');
103+
client.getTreatment('emi@split.io', 'always_on_impressions_disabled_true');
104104

105105
client.destroy().then(() => {
106106
assert.end();

‎src/__tests__/nodeSuites/impressions.spec.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ export default async function (key, fetchMock, assert) {
5555
const dependencyChildImpr = data.filter(e => e.f === 'hierarchical_splits_test')[0];
5656
const splitWithConfigImpr = data.filter(e => e.f === 'split_with_config')[0];
5757
const notExistentSplitImpr = data.filter(e => e.f === 'not_existent_split')[0];
58-
const alwaysOnWithTrackImpressionsFalse = data.filter(e => e.f === 'always_on_track_impressions_false');
58+
const alwaysOnWithImpressionsDisabledTrue = data.filter(e => e.f === 'always_on_impressions_disabled_true');
5959

6060
assert.equal(notExistentSplitImpr.i.length, 1); // Only one, the split not found is filtered by the non existent Split check.
6161
assert.equal(splitWithConfigImpr.i.length, 2);
6262
assert.equal(dependencyChildImpr.i.length, 1);
63-
assert.equal(alwaysOnWithTrackImpressionsFalse.length, 0);
63+
assert.equal(alwaysOnWithImpressionsDisabledTrue.length, 0);
6464

6565
assert.true(dependencyChildImpr, 'Split we wanted to evaluate should be present on the impressions.');
6666
assert.false(data.some(e => e.f === 'hierarchical_dep_always_on'), 'Parent split evaluations should not result in impressions.');
@@ -111,21 +111,21 @@ export default async function (key, fetchMock, assert) {
111111

112112
// finding these validate the feature names collection too
113113
const splitWithConfigImpr = data.pf.filter(e => e.f === 'split_with_config')[0];
114-
const alwaysOnWithTrackImpressionsFalse = data.pf.filter(e => e.f === 'always_on_track_impressions_false')[0];
114+
const alwaysOnWithImpressionsDisabledTrue = data.pf.filter(e => e.f === 'always_on_impressions_disabled_true')[0];
115115

116116
assert.equal(splitWithConfigImpr.rc, 1);
117117
assert.equal(typeof splitWithConfigImpr.m, 'number');
118118
assert.equal(splitWithConfigImpr.m, truncatedTimeFrame);
119-
assert.equal(alwaysOnWithTrackImpressionsFalse.rc, 1);
120-
assert.equal(typeof alwaysOnWithTrackImpressionsFalse.m, 'number');
121-
assert.equal(alwaysOnWithTrackImpressionsFalse.m, truncatedTimeFrame);
119+
assert.equal(alwaysOnWithImpressionsDisabledTrue.rc, 1);
120+
assert.equal(typeof alwaysOnWithImpressionsDisabledTrue.m, 'number');
121+
assert.equal(alwaysOnWithImpressionsDisabledTrue.m, truncatedTimeFrame);
122122

123123
return 200;
124124
});
125125

126126
fetchMock.postOnce(url(settings, '/v1/keys/ss'), (url, opts) => {
127127
assert.deepEqual(JSON.parse(opts.body), {
128-
keys: [{ f: 'always_on_track_impressions_false', ks: ['other_key'] }]
128+
keys: [{ f: 'always_on_impressions_disabled_true', ks: ['other_key'] }]
129129
}, 'We should only track unique keys for features flags with track impressions disabled.');
130130

131131
return 200;
@@ -154,7 +154,7 @@ export default async function (key, fetchMock, assert) {
154154
client.getTreatmentWithConfig({ matchingKey: 'different', bucketingKey: 'test_buck_key' }, 'split_with_config');
155155

156156
// Impression should not be tracked
157-
assert.equal(client.getTreatment('other_key', 'always_on_track_impressions_false'), 'on');
157+
assert.equal(client.getTreatment('other_key', 'always_on_impressions_disabled_true'), 'on');
158158

159159
evaluationsEnd = Date.now();
160160
}

0 commit comments

Comments
 (0)