2nd step: move SplitIO namespace definition from React Native SDK to JS-Commons and merge

Author: EmilianoSanchez

src/splitFactory.ts

@@ -6,7 +6,7 @@ import { getFetch } from './platform/getFetch';
 import { getEventSource } from './platform/getEventSource';
 import { EventEmitter } from '@splitsoftware/splitio-commons/src/utils/MinEvents';
 import { now } from '@splitsoftware/splitio-commons/src/utils/timeTracker/now/browser';
-import { IBrowserSettings } from '../types/splitio';
+import SplitIO from '@splitsoftware/splitio-commons/types/splitio';
 
 const platform = { getFetch, getEventSource, EventEmitter, now };
 
@@ -18,7 +18,7 @@ const platform = { getFetch, getEventSource, EventEmitter, now };
  * caution since, unlike `config`, this param is not validated neither considered part of the public API.
  * @throws Will throw an error if the provided config is invalid.
  */
-export function SplitFactory(config: IBrowserSettings, __updateModules?: (modules: ISdkFactoryParams) => void) {
+export function SplitFactory(config: SplitIO.IClientSideSettings, __updateModules?: (modules: ISdkFactoryParams) => void) {
   const settings = settingsFactory(config);
   const modules = getModules(settings, platform);
   if (__updateModules) __updateModules(modules);

ts-tests/index.ts

@@ -32,8 +32,8 @@ let SDK: SplitIO.ISDK;
 // Settings interfaces
 // let nodeSettings: SplitIO.INodeSettings;
 // let asyncSettings: SplitIO.INodeAsyncSettings;
-let browserSettings: SplitIO.IBrowserSettings;
-let browserAsyncSettings: SplitIO.IBrowserAsyncSettings;
+let browserSettings: SplitIO.IClientSideSettings;
+let browserAsyncSettings: SplitIO.IClientSideAsyncSettings;
 // Client & Manager APIs
 // let client: SplitIO.IClient;
 let client: SplitIO.IClient;
@@ -518,7 +518,7 @@ userConsent = AsyncSDK.UserConsent.Status.UNKNOWN;
 // Split filters
 let splitFilters: SplitIO.SplitFilter[] = [{ type: 'bySet', values: ['set_a', 'set_b'] }, { type: 'byName', values: ['my_split_1', 'my_split_1'] }, { type: 'byPrefix', values: ['my_split', 'test_split_'] }]
 
-let fullBrowserSettings: SplitIO.IBrowserSettings = {
+let fullBrowserSettings: SplitIO.IClientSideSettings = {
   core: {
     authorizationKey: 'asd',
     key: 'asd',
@@ -568,7 +568,7 @@ let fullBrowserSettings: SplitIO.IBrowserSettings = {
 fullBrowserSettings.userConsent = 'DECLINED';
 fullBrowserSettings.userConsent = 'UNKNOWN';
 
-let fullBrowserAsyncSettings: SplitIO.IBrowserAsyncSettings = {
+let fullBrowserAsyncSettings: SplitIO.IClientSideAsyncSettings = {
   mode: 'consumer',
   core: {
     authorizationKey: 'asd',

types/index.d.ts

@@ -10,11 +10,11 @@ declare module JsSdk {
   /**
    * Split.io SDK factory function.
    *
-   * The settings parameter should be an object that complies with the SplitIO.IBrowserSettings.
+   * The settings parameter should be an object that complies with the SplitIO.IClientSideSettings or SplitIO.IClientSideAsyncSettings interfaces.
    * For more information read the corresponding article: @see {@link https://help.split.io/hc/en-us/articles/360058730852-Browser-SDK#configuration}
    */
-  export function SplitFactory(settings: SplitIO.IBrowserSettings): SplitIO.ISDK;
-  export function SplitFactory(settings: SplitIO.IBrowserAsyncSettings): SplitIO.IAsyncSDK;
+  export function SplitFactory(config: SplitIO.IClientSideSettings): SplitIO.ISDK;
+  export function SplitFactory(config: SplitIO.IClientSideAsyncSettings): SplitIO.IAsyncSDK;
 
   /**
    * Persistent storage based on the LocalStorage Web API for browsers.