Remove 'full' subpackage, since there is not significant difference with the default 'slim' subpackage

Author: EmilianoSanchez

CHANGES.txt

@@ -6,6 +6,7 @@
     - Removed internal ponyfills for the `Map` and `Set` global objects, dropping support for IE and other outdated browsers. The SDK now requires the runtime environment to support these features natively or provide a polyfill.
     - Removed the deprecated `GoogleAnalyticsToSplit` and `SplitToGoogleAnalytics` pluggable integration modules, along with the related interfaces in the TypeScript definitions.
     - Removed the `LocalhostFromObject` export from the "slim" entrypoint (`import { LocalhostFromObject } from '@splitsoftware/splitio-browserjs'`). It is no longer necessary to manually import and configure it in the `sync.localhostMode` option to enable localhost mode.
+    - Removed the "full" entrypoint (`import { SplitFactory } from '@splitsoftware/splitio-browserjs/full'`), since with the removal of `LocalhostFromObject` from the "slim" entrypoint, the difference between "slim" and "full" entrypoints is minimal. The "full" entrypoint differs only by including the `unfetch` ponyfill to support older browsers.
 
 0.15.0 (September 13, 2024)
  - Updated @splitsoftware/splitio-commons package to version 1.17.0 that includes minor updates:

full/package.json

@@ -13,8 +13,7 @@
     "cjs",
     "esm",
     "src",
-    "types",
-    "full"
+    "types"
   ],
   "scripts": {
     "check": "npm run check:lint && npm run check:types && npm run check:version",
@@ -62,8 +61,7 @@
   "homepage": "https://github.com/splitio/javascript-browser-client#readme",
   "dependencies": {
     "@splitsoftware/splitio-commons": "2.0.0-rc.2",
-    "tslib": "^2.3.1",
-    "unfetch": "^4.2.0"
+    "tslib": "^2.3.1"
   },
   "devDependencies": {
     "@rollup/plugin-commonjs": "^24.0.1",

package-lock.json

@@ -35,7 +35,7 @@ export default env => {
      *
      * Only https://www.npmjs.com/package/rollup-plugin-ts compiles from node_modules, and is used for tests.
      */
-    createRollupConfig('esm/full/umd.js', 'full'), // umd/split-browser-VERSION.full[.min].js
+    createRollupConfig('esm/umd-full.js', 'full'), // umd/split-browser-VERSION.full[.min].js
     createRollupConfig('esm/umd.js') // umd/split-browser-VERSION[.min].js
   ];
 };

package.json

@@ -2,8 +2,7 @@ import tape from 'tape-catch';
 import sinon from 'sinon';
 import fetchMock from '../testUtils/fetchMock';
 import { url } from '../testUtils';
-import { SplitFactory, InLocalStorage } from '../../full';
-import { SplitFactory as SplitFactorySlim } from '../../';
+import { SplitFactory, InLocalStorage } from '../../index';
 import { settingsFactory } from '../../settings';
 
 const settings = settingsFactory({ core: { key: 'facundo@split.io' } });
@@ -88,18 +87,15 @@ tape('Browser offline mode', function (assert) {
     sharedUpdateCount++;
   });
 
-  const factoriesReadyFromCache = [
-    SplitFactory({ ...config, storage: InLocalStorage() }),
-    SplitFactorySlim({ ...config, storage: InLocalStorage() })
-  ];
+  const factoryReadyFromCache = SplitFactory({ ...config, storage: InLocalStorage() });
   const configs = [
     { ...config, features: { ...config.features }, storage: InLocalStorage /* invalid */ },
     { ...config },
     config,
   ];
   const factories = [
     ...configs.map(config => SplitFactory(config)),
-    ...factoriesReadyFromCache
+    factoryReadyFromCache
   ];
 
   let readyCount = 0, updateCount = 0, readyFromCacheCount = 0;
@@ -361,7 +357,7 @@ tape('Browser offline mode', function (assert) {
           // SDK events on other factory clients
           assert.equal(readyCount, factories.length, 'Each factory client should have emitted SDK_READY event once');
           assert.equal(updateCount, factories.length - 1, 'Each factory client except one should have emitted SDK_UPDATE event once');
-          assert.equal(readyFromCacheCount, factoriesReadyFromCache.length * 2, 'The main and shared client of the factories with LOCALSTORAGE should have emitted SDK_READY_FROM_CACHE event');
+          assert.equal(readyFromCacheCount, 2, 'The main and shared client of the factory with LOCALSTORAGE should have emitted SDK_READY_FROM_CACHE event');
 
           assert.end();
         });

rollup.ci.config.js

@@ -1,18 +1,15 @@
-import { settingsFactory as slimSettingsFactory } from '../index';
-import { settingsFactory as fullSettingsFactory } from '../full';
+import { settingsFactory } from '../index';
 
 test('SETTINGS / Consent is overwritable and "GRANTED" by default', () => {
-  [slimSettingsFactory, fullSettingsFactory].forEach((settingsFactory) => {
-    let settings = settingsFactory({});
-    expect(settings.userConsent).toEqual('GRANTED'); // userConsent defaults to granted if not provided
+  let settings = settingsFactory({});
+  expect(settings.userConsent).toEqual('GRANTED'); // userConsent defaults to granted if not provided
 
-    settings = settingsFactory({ userConsent: 'INVALID-VALUE' });
-    expect(settings.userConsent).toEqual('GRANTED'); // userConsent defaults to granted if a wrong value is provided
+  settings = settingsFactory({ userConsent: 'INVALID-VALUE' });
+  expect(settings.userConsent).toEqual('GRANTED'); // userConsent defaults to granted if a wrong value is provided
 
-    settings = settingsFactory({ userConsent: 'UNKNOWN' });
-    expect(settings.userConsent).toEqual('UNKNOWN'); // userConsent can be overwritten
+  settings = settingsFactory({ userConsent: 'UNKNOWN' });
+  expect(settings.userConsent).toEqual('UNKNOWN'); // userConsent can be overwritten
 
-    settings = settingsFactory({ userConsent: 'declined' });
-    expect(settings.userConsent).toEqual('DECLINED'); // userConsent can be overwritten
-  });
+  settings = settingsFactory({ userConsent: 'declined' });
+  expect(settings.userConsent).toEqual('DECLINED'); // userConsent can be overwritten
 });

src/__tests__/offline/browser.spec.js

@@ -2,7 +2,7 @@ import { settingsFactory } from './settings';
 import { getModules } from './platform/getModules';
 import { sdkFactory } from '@splitsoftware/splitio-commons/src/sdkFactory/index';
 import { ISdkFactoryParams } from '@splitsoftware/splitio-commons/src/sdkFactory/types';
-import { getFetch } from './platform/getFetchSlim';
+import { getFetch } from './platform/getFetch';
 import { getEventSource } from './platform/getEventSource';
 import { EventEmitter } from '@splitsoftware/splitio-commons/src/utils/MinEvents';
 import { now } from '@splitsoftware/splitio-commons/src/utils/timeTracker/now/browser';
@@ -11,8 +11,7 @@ import { IBrowserSettings } from '../types/splitio';
 const platform = { getFetch, getEventSource, EventEmitter, now };
 
 /**
- * Slim SplitFactory with pluggable modules for Browser.
- * Doesn't include fetch ponyfill out-of-the-box.
+ * SplitFactory with pluggable modules for Browser.
  *
  * @param config configuration object used to instantiate the SDK
  * @param __updateModules optional function that lets redefine internal SDK modules. Use with

src/full/index.ts

@@ -11,13 +11,8 @@
  * @author Nico Zelaya <nicolas.zelaya@split.io>
  */
 
-import { SplitFactory as SplitFactoryFull, InLocalStorage as InLocalStorageFull, DebugLogger as DebugLoggerFull, InfoLogger as InfoLoggerFull, WarnLogger as WarnLoggerFull, ErrorLogger as ErrorLoggerFull, PluggableStorage as PluggableStorageFull } from '@splitsoftware/splitio-browserjs/full';
 import { SplitFactory, InLocalStorage, DebugLogger, InfoLogger, WarnLogger, ErrorLogger, PluggableStorage } from '@splitsoftware/splitio-browserjs';
 
-// Entry points must export the same objects
-let splitFactory = SplitFactory; splitFactory = SplitFactoryFull;
-let inLocalStorage = InLocalStorage; inLocalStorage = InLocalStorageFull;
-let pluggableStorage = PluggableStorage; pluggableStorage = PluggableStorageFull;
 
 let stringPromise: Promise<string>;
 let splitNamesPromise: Promise<SplitIO.SplitNames>;
@@ -626,10 +621,6 @@ fullBrowserSettings.debug = DebugLogger();
 fullBrowserSettings.debug = InfoLogger();
 fullBrowserSettings.debug = WarnLogger();
 fullBrowserSettings.debug = ErrorLogger();
-fullBrowserSettings.debug = DebugLoggerFull();
-fullBrowserSettings.debug = InfoLoggerFull();
-fullBrowserSettings.debug = WarnLoggerFull();
-fullBrowserSettings.debug = ErrorLoggerFull();
 
 // let fullNodeSettings: SplitIO.INodeSettings = {
 //   core: {

src/full/splitFactory.ts

@@ -7,9 +7,7 @@ export = JsSdk;
 
 declare module JsSdk {
   /**
-   * Slim version of the Split.io SDK factory function.
-   *
-   * Recommended to use for bundle size reduction in production, since it doesn't include a 'fetch' polyfill out-of-the-box
+   * Split.io SDK factory function.
    *
    * The settings parameter should be an object that complies with the SplitIO.IBrowserSettings.
    * For more information read the corresponding article: @see {@link https://help.split.io/hc/en-us/articles/360058730852-Browser-SDK#configuration}