From 661570c5f8723343029100224356cc1f9040682b Mon Sep 17 00:00:00 2001 From: gb-123-git <64229388+gb-123-git@users.noreply.github.com> Date: Sat, 20 Nov 2021 17:59:30 +0530 Subject: [PATCH 1/3] Commented RECEIVE_TIMEOUT_VALUE as variable seems unused The variables 'RECEIVE_TIMEOUT_VALUE' in SX1509::readByte & SX1509::readWord seem to be unused. Commented. --- src/SparkFunSX1509.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/SparkFunSX1509.cpp b/src/SparkFunSX1509.cpp index d92197f..3942710 100644 --- a/src/SparkFunSX1509.cpp +++ b/src/SparkFunSX1509.cpp @@ -727,7 +727,8 @@ uint8_t SX1509::calculateSlopeRegister(uint8_t ms, uint8_t onIntensity, uint8_t uint8_t SX1509::readByte(uint8_t registerAddress) { uint8_t readValue; - uint16_t timeout = RECEIVE_TIMEOUT_VALUE; + // Commented the line as variable seems unused; + //uint16_t timeout = RECEIVE_TIMEOUT_VALUE; _i2cPort->beginTransmission(deviceAddress); _i2cPort->write(registerAddress); @@ -748,6 +749,7 @@ uint16_t SX1509::readWord(uint8_t registerAddress) { uint16_t readValue; uint16_t msb, lsb; + // Commented the line as variable seems unused; uint16_t timeout = RECEIVE_TIMEOUT_VALUE * 2; _i2cPort->beginTransmission(deviceAddress); From b4aac508b0226b1aad5825b21d364f6bde688c51 Mon Sep 17 00:00:00 2001 From: gb-123-git <64229388+gb-123-git@users.noreply.github.com> Date: Mon, 29 Nov 2021 04:23:41 +0530 Subject: [PATCH 2/3] Update SparkFunSX1509.cpp --- src/SparkFunSX1509.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SparkFunSX1509.cpp b/src/SparkFunSX1509.cpp index 3942710..78bf54a 100644 --- a/src/SparkFunSX1509.cpp +++ b/src/SparkFunSX1509.cpp @@ -750,7 +750,7 @@ uint16_t SX1509::readWord(uint8_t registerAddress) uint16_t readValue; uint16_t msb, lsb; // Commented the line as variable seems unused; - uint16_t timeout = RECEIVE_TIMEOUT_VALUE * 2; + //uint16_t timeout = RECEIVE_TIMEOUT_VALUE * 2; _i2cPort->beginTransmission(deviceAddress); _i2cPort->write(registerAddress); From e3d7bbd81645652211142c24d287fd62bbccfbde Mon Sep 17 00:00:00 2001 From: gb-123-git <64229388+gb-123-git@users.noreply.github.com> Date: Mon, 29 Nov 2021 04:26:05 +0530 Subject: [PATCH 3/3] Bug Fix --- src/SparkFunSX1509.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SparkFunSX1509.cpp b/src/SparkFunSX1509.cpp index 78bf54a..9671a8a 100644 --- a/src/SparkFunSX1509.cpp +++ b/src/SparkFunSX1509.cpp @@ -544,7 +544,7 @@ void SX1509::debounceTime(uint8_t time) uint8_t configValue = 0; // We'll check for the highest set bit position, // and use that for debounceConfig - for (uint8_t i = 7; i >= 0; i--) + for (int8_t i = 7; i >= 0; i--) { if (time & (1 << i)) {