PLEASE CHECK: should retries be int32_t ? Avoids can't-be-<-0 warning-as-error

PaulZC · PaulZC · commit cd7abd2cc5f6 · 2022-10-18T10:36:17.000+01:00
diff --git a/src/tmf882x_mode_app.c b/src/tmf882x_mode_app.c
@@ -417,7 +417,7 @@ static uint8_t get_app_cmd_stat(struct tmf882x_mode_app *app)
 }
 
 static int32_t check_cmd_status(struct tmf882x_mode_app *app,
-                            uint32_t retries)
+                            int32_t retries)
 {
     int32_t num_retries;
     uint8_t status;

Original file line number	Diff line number	Diff line change
`@@ -417,7 +417,7 @@ static uint8_t get_app_cmd_stat(struct tmf882x_mode_app *app)`
`417`	`417`	`}`
`418`	`418`
`419`	`419`	`static int32_t check_cmd_status(struct tmf882x_mode_app *app,`
`420`		`- uint32_t retries)`
	`420`	`+ int32_t retries)`
`421`	`421`	`{`
`422`	`422`	`int32_t num_retries;`
`423`	`423`	`uint8_t status;`