From 54cb5105500874b6b20539754a8e782546e7d0be Mon Sep 17 00:00:00 2001 From: oclyke Date: Tue, 13 Oct 2020 12:17:30 -0600 Subject: [PATCH 1/2] add upload maximums to boards fixes #121 arduino requires each board to define its own maximum flash and data sizes this goes hand-in-hand with the upload.size.pattern and upload.size.regex(.data) fields in platform.txt both must be present to display sketch size information arduino should consider using inheritance in board definitions (see mbed targets.json) - it would save a lot of duplication --- boards.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/boards.txt b/boards.txt index 46f5a360..dc06ddf2 100644 --- a/boards.txt +++ b/boards.txt @@ -13,6 +13,8 @@ sfe_artemis_dk.build.core=arduino sfe_artemis_dk.build.variant=SFE_ARTEMIS_DK sfe_artemis_dk.build.arch=APOLLO3 sfe_artemis_dk.build.board=APOLLO3_SFE_ARTEMIS_DK +sfe_artemis_dk.upload.maximum_size=983040 +sfe_artemis_dk.upload.maximum_data_size=393216 sfe_artemis_dk.build.export_format=bin sfe_artemis_dk.build.defines= sfe_artemis_dk.build.includes= @@ -27,6 +29,8 @@ sfe_artemis.build.core=arduino sfe_artemis.build.variant=SFE_ARTEMIS sfe_artemis.build.arch=APOLLO3 sfe_artemis.build.board=APOLLO3_SFE_ARTEMIS +sfe_artemis.upload.maximum_size=983040 +sfe_artemis.upload.maximum_data_size=393216 sfe_artemis.build.export_format=bin sfe_artemis.build.defines= sfe_artemis.build.includes= @@ -61,6 +65,8 @@ sfe_artemis_atp.build.core=arduino sfe_artemis_atp.build.variant=SFE_ARTEMIS_ATP sfe_artemis_atp.build.arch=APOLLO3 sfe_artemis_atp.build.board=APOLLO3_SFE_ARTEMIS_ATP +sfe_artemis_atp.upload.maximum_size=983040 +sfe_artemis_atp.upload.maximum_data_size=393216 sfe_artemis_atp.build.export_format=bin sfe_artemis_atp.build.defines= sfe_artemis_atp.build.includes= @@ -95,6 +101,8 @@ sfe_artemis_nano.build.core=arduino sfe_artemis_nano.build.variant=SFE_ARTEMIS_NANO sfe_artemis_nano.build.arch=APOLLO3 sfe_artemis_nano.build.board=APOLLO3_SFE_ARTEMIS_NANO +sfe_artemis_nano.upload.maximum_size=983040 +sfe_artemis_nano.upload.maximum_data_size=393216 sfe_artemis_nano.build.export_format=bin sfe_artemis_nano.build.defines= sfe_artemis_nano.build.includes= @@ -129,6 +137,8 @@ sfe_artemis_thing_plus.build.core=arduino sfe_artemis_thing_plus.build.variant=SFE_ARTEMIS_THING_PLUS sfe_artemis_thing_plus.build.arch=APOLLO3 sfe_artemis_thing_plus.build.board=APOLLO3_SFE_ARTEMIS_THING_PLUS +sfe_artemis_thing_plus.upload.maximum_size=983040 +sfe_artemis_thing_plus.upload.maximum_data_size=393216 sfe_artemis_thing_plus.build.export_format=bin sfe_artemis_thing_plus.build.defines= sfe_artemis_thing_plus.build.includes= @@ -163,6 +173,8 @@ sfe_edge.build.core=arduino sfe_edge.build.variant=SFE_EDGE sfe_edge.build.arch=APOLLO3 sfe_edge.build.board=APOLLO3_SFE_EDGE +sfe_edge.upload.maximum_size=983040 +sfe_edge.upload.maximum_data_size=393216 sfe_edge.build.export_format=bin sfe_edge.build.defines= sfe_edge.build.includes= @@ -202,6 +214,8 @@ sfe_edge2.build.core=arduino sfe_edge2.build.variant=SFE_EDGE2 sfe_edge2.build.arch=APOLLO3 sfe_edge2.build.board=APOLLO3_SFE_EDGE2 +sfe_edge2.upload.maximum_size=983040 +sfe_edge2.upload.maximum_data_size=393216 sfe_edge2.build.export_format=bin sfe_edge2.build.defines= sfe_edge2.build.includes= @@ -236,6 +250,8 @@ sfe_artemis_module.build.core=arduino sfe_artemis_module.build.variant=SFE_ARTEMIS_MODULE sfe_artemis_module.build.arch=APOLLO3 sfe_artemis_module.build.board=APOLLO3_SFE_ARTEMIS_MODULE +sfe_artemis_module.upload.maximum_size=983040 +sfe_artemis_module.upload.maximum_data_size=393216 sfe_artemis_module.build.export_format=bin sfe_artemis_module.build.defines= sfe_artemis_module.build.includes= From 4940e51da172060f606e822bb185d1a14afe92cd Mon Sep 17 00:00:00 2001 From: Wenn0101 Date: Fri, 16 Oct 2020 13:57:53 -0600 Subject: [PATCH 2/2] add upload maximums for artemis_mm_pb --- boards.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boards.txt b/boards.txt index 93c15496..c1d4ad6d 100644 --- a/boards.txt +++ b/boards.txt @@ -250,6 +250,8 @@ sfe_artemis_mm_pb.build.core=arduino sfe_artemis_mm_pb.build.variant=SFE_ARTEMIS_MM_PB sfe_artemis_mm_pb.build.arch=APOLLO3 sfe_artemis_mm_pb.build.board=APOLLO3_SFE_ARTEMIS_MM_PB +sfe_artemis_mm_pb.upload.maximum_size=983040 +sfe_artemis_mm_pb.upload.maximum_data_size=393216 sfe_artemis_mm_pb.build.export_format=bin sfe_artemis_mm_pb.build.defines= sfe_artemis_mm_pb.build.includes=