Skip to content

Commit a17accd

Browse files
committed
Remove 'ap3_post_variant.h'
Functionality is moved to individual modules, particularly because the include order was incorrect causing redefinitions of symbols like 'SS' by the variant files
1 parent 7dbc983 commit a17accd

File tree

3 files changed

+14
-25
lines changed

3 files changed

+14
-25
lines changed

cores/arduino/ard_sup/Arduino.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,4 @@ extern "C"
8383

8484
#include "variant.h"
8585

86-
#include "ap3_post_variant.h"
87-
8886
#endif // _ARDUINO_H_

cores/arduino/ard_sup/ap3_post_variant.h

Lines changed: 0 additions & 23 deletions
This file was deleted.

libraries/SPI/src/SPI.h

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,20 @@
2323
#include <Arduino.h>
2424
#include "ap3_iomaster.h"
2525

26+
// Give a warning if the variant did not define these symbols:
27+
#ifndef SS
28+
#warning "variant has no definition for pin number 'SS'"
29+
#endif // SS
30+
#ifndef MOSI
31+
#warning "variant has no definition for pin number 'MOSI'"
32+
#endif // MOSI
33+
#ifndef MISO
34+
#warning "variant has no definition for pin number 'MISO'"
35+
#endif // MISO
36+
#ifndef CLK
37+
#warning "variant has no definition for pin number 'CLK'"
38+
#endif // CLK
39+
2640
// SPI_HAS_TRANSACTION means SPI has
2741
// - beginTransaction()
2842
// - endTransaction()

0 commit comments

Comments
 (0)