Fix INPUT_PULLUP issue #8

nseidle · nseidle · commit 93843866d0f3 · 2019-06-18T20:32:29.000-06:00
diff --git a/cores/arduino/am_sdk_ap3/mcu/apollo3/hal/am_hal_gpio.c b/cores/arduino/am_sdk_ap3/mcu/apollo3/hal/am_hal_gpio.c
@@ -432,9 +432,9 @@ am_hal_gpio_pinconfig(uint32_t ui32Pin, am_hal_gpio_pincfg_t bfGpioCfg)
                 return AM_HAL_GPIO_ERR_PULLDOWN;
             }
         }
-        else if (bfGpioCfg.ePullup == AM_HAL_GPIO_PIN_PULLUP_WEAK)
+        else if (bfGpioCfg.ePullup != AM_HAL_GPIO_PIN_PULLUP_WEAK)
         {
-            if (g_ui8Bit76Capabilities[ui32Pin] & (CAP_PUP | CAP_PDN))
+            if ((g_ui8Bit76Capabilities[ui32Pin] & (CAP_PUP | CAP_PDN)) == 0)
             {
                 return AM_HAL_GPIO_ERR_PULLUP;
             }

Original file line number	Diff line number	Diff line change
`@@ -432,9 +432,9 @@ am_hal_gpio_pinconfig(uint32_t ui32Pin, am_hal_gpio_pincfg_t bfGpioCfg)`
`432`	`432`	`return AM_HAL_GPIO_ERR_PULLDOWN;`
`433`	`433`	`}`
`434`	`434`	`}`
`435`		`- else if (bfGpioCfg.ePullup == AM_HAL_GPIO_PIN_PULLUP_WEAK)`
	`435`	`+ else if (bfGpioCfg.ePullup != AM_HAL_GPIO_PIN_PULLUP_WEAK)`
`436`	`436`	`{`
`437`		`- if (g_ui8Bit76Capabilities[ui32Pin] & (CAP_PUP \| CAP_PDN))`
	`437`	`+ if ((g_ui8Bit76Capabilities[ui32Pin] & (CAP_PUP \| CAP_PDN)) == 0)`
`438`	`438`	`{`
`439`	`439`	`return AM_HAL_GPIO_ERR_PULLUP;`
`440`	`440`	`}`