fixup pipBulkShow function to prevent breaking with numerous names

ficapy · ficapy · commit c1e5d8abaf03 · 2023-05-14T23:04:14.000+08:00
diff --git a/packages/pyright-scip/src/virtualenv/environment.ts b/packages/pyright-scip/src/virtualenv/environment.ts
@@ -33,10 +33,10 @@ function pipList(): PipInformation[] {
 }
 
 function pipBulkShow(names: string[]): string[] {
-    // TODO: This probably breaks with enough names. Should batch them into 512 or whatever the max for bash would be
+    const maxBuffer = 1024 * 1024 * 10; // 10MB
     return child_process
-        .execSync(`${getPipCommand()} show -f ${names.join(' ')}`)
-        .toString()
+        .spawnSync(getPipCommand(), ['show', '-f', `${names.join(' ')}`], {maxBuffer})
+        .stdout.toString()
         .split('---');
 }
 

Original file line number	Diff line number	Diff line change
`@@ -33,10 +33,10 @@ function pipList(): PipInformation[] {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`function pipBulkShow(names: string[]): string[] {`
`36`		`- // TODO: This probably breaks with enough names. Should batch them into 512 or whatever the max for bash would be`
	`36`	`+ const maxBuffer = 1024 * 1024 * 10; // 10MB`
`37`	`37`	`return child_process`
`38`		- .execSync(`${getPipCommand()} show -f ${names.join(' ')}`)
`39`		`- .toString()`
	`38`	+ .spawnSync(getPipCommand(), ['show', '-f', `${names.join(' ')}`], {maxBuffer})
	`39`	`+ .stdout.toString()`
`40`	`40`	`.split('---');`
`41`	`41`	`}`
`42`	`42`