From d32e5eed9fe47134e85b613b5dab6211b0753c09 Mon Sep 17 00:00:00 2001
From: Matthias Kern <matthias_kern@posteo.net>
Date: Tue, 8 May 2018 13:48:00 +0300
Subject: [PATCH] feat(typescript): upgrade to typescript 2.8.3

---
 package-lock.json                      |  6 +++---
 package.json                           |  2 +-
 src/diagnostics.ts                     |  3 ++-
 src/test/typescript-service-helpers.ts | 12 ++++++------
 4 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index c99e0dd9c..b187a7435 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -7450,9 +7450,9 @@
       "dev": true
     },
     "typescript": {
-      "version": "2.7.2",
-      "resolved": "https://registry.npmjs.org/typescript/-/typescript-2.7.2.tgz",
-      "integrity": "sha512-p5TCYZDAO0m4G344hD+wx/LATebLWZNkkh2asWUFqSsD2OrDNhbAHuSjobrmsUmdzjJjEeZVU9g1h3O6vpstnw=="
+      "version": "2.8.3",
+      "resolved": "https://registry.npmjs.org/typescript/-/typescript-2.8.3.tgz",
+      "integrity": "sha512-K7g15Bb6Ra4lKf7Iq2l/I5/En+hLIHmxWZGq3D4DIRNFxMNV6j2SHSvDOqs2tGd4UvD/fJvrwopzQXjLrT7Itw=="
     },
     "uglify-js": {
       "version": "2.8.29",
diff --git a/package.json b/package.json
index bff1f7024..c92d2f998 100644
--- a/package.json
+++ b/package.json
@@ -51,7 +51,7 @@
     "rxjs": "^5.5.0",
     "semaphore-async-await": "^1.5.1",
     "string-similarity": "^1.1.0",
-    "typescript": "2.7.2",
+    "typescript": "2.8.3",
     "vscode-jsonrpc": "^3.3.1",
     "vscode-languageserver": "^3.1.0",
     "vscode-languageserver-types": "^3.0.3"
diff --git a/src/diagnostics.ts b/src/diagnostics.ts
index 1a7a62d80..4ec7c3376 100644
--- a/src/diagnostics.ts
+++ b/src/diagnostics.ts
@@ -35,6 +35,7 @@ function convertDiagnosticCategory(category: ts.DiagnosticCategory): DiagnosticS
             return DiagnosticSeverity.Warning
         case ts.DiagnosticCategory.Message:
             return DiagnosticSeverity.Information
-        // unmapped: DiagnosticSeverity.Hint
+        case ts.DiagnosticCategory.Suggestion:
+            return DiagnosticSeverity.Hint
     }
 }
diff --git a/src/test/typescript-service-helpers.ts b/src/test/typescript-service-helpers.ts
index 74ae96a16..3b0a7dc62 100644
--- a/src/test/typescript-service-helpers.ts
+++ b/src/test/typescript-service-helpers.ts
@@ -2297,11 +2297,11 @@ export function describeTypeScriptService(
                             uri: 'git://github.com/Microsoft/TypeScript?v' + ts.version + '#lib/lib.dom.d.ts',
                             range: {
                                 start: {
-                                    line: 8446,
+                                    line: 9378,
                                     character: 10,
                                 },
                                 end: {
-                                    line: 8446,
+                                    line: 9378,
                                     character: 14,
                                 },
                             },
@@ -2310,11 +2310,11 @@ export function describeTypeScriptService(
                             uri: 'git://github.com/Microsoft/TypeScript?v' + ts.version + '#lib/lib.dom.d.ts',
                             range: {
                                 start: {
-                                    line: 8498,
+                                    line: 9429,
                                     character: 12,
                                 },
                                 end: {
-                                    line: 8498,
+                                    line: 9429,
                                     character: 16,
                                 },
                             },
@@ -3309,8 +3309,8 @@ export function describeTypeScriptService(
                             fileName: toUnixPath(uri2path(rootUri + 'a.ts')), // path only used by TS service
                             textChanges: [
                                 {
-                                    span: { start: 49, length: 13 },
-                                    newText: '\t\tthis.missingThis',
+                                    span: { start: 51, length: 11 },
+                                    newText: 'this.missingThis',
                                 },
                             ],
                         },