This repository was archived by the owner on Oct 16, 2020. It is now read-only.
fix(serve): only restart workers if their exit was uninentional #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
approved these changes
Jun 6, 2018
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 15 15
Lines 2043 2043
Branches 416 416
=======================================
Hits 1697 1697
Misses 344 344
Partials 2 2Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 2.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the cluster's workers would restart even if the master intentionally called
worker.kill(). The workers should only restart if they crashed, not if the master intended for them to die.