This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Add missing project method for plugins #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in fact, many other methods have to be set there, since Project implements LanguageServiceHost.
This was referenced May 18, 2018
soywod
changed the title
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
- Coverage 83.1% 83.06% -0.05%
==========================================
Files 15 15
Lines 2042 2043 +1
Branches 416 483 +67
==========================================
Hits 1697 1697
- Misses 343 344 +1
Partials 2 2
Continue to review full report at Codecov.
|
src/plugins.ts
Outdated
| @@ -40,6 +40,7 @@ export interface PluginCreateInfo { | |||
| * The portion of tsserver's Project API exposed to plugins | |||
| */ | |||
| export interface Project { | |||
| getCurrentDirectory: () => string | |||
There was a problem hiding this comment.
Style nit, could this just be a method rather than an arrow function?
getCurrentDirectory(): string
There was a problem hiding this comment.
Yes you right, I update this
src/project-manager.ts
Outdated
| project: { projectService: { logger: this.logger } }, // TODO: may need more support | ||
| project: { | ||
| // TODO: may need more support | ||
| getCurrentDirectory: this.getHost().getCurrentDirectory.bind(this), |
There was a problem hiding this comment.
bind() is not type safe, prefer wrapping in a function manually
felixfbecker
approved these changes
May 30, 2018
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using tslint-language-service, and this plugin doesn't work with javascript-typescript-langserver because there is some missing properties/methods in your PluginCreateInfo. So I just added the
getCurrentDirectory.