This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Empty handler for initialized notification #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 15 15
Lines 1765 1765
Branches 333 333
=======================================
Hits 1317 1317
Misses 296 296
Partials 152 152
Continue to review full report at Codecov.
|
src/typescript-service.ts
Outdated
| @@ -1324,6 +1324,10 @@ export class TypeScriptService { | |||
| .startWith({ op: 'add', path: '', value: { changes: {} } as WorkspaceEdit } as Operation) | |||
| } | |||
|
|
|||
| public async initialized(): Promise<void> { | |||
There was a problem hiding this comment.
please copy over the description
felixfbecker
approved these changes
Oct 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language server currently logs a warning when the
initializednotification is received.As we are not dynamically registering capabilities on the client, there should be nothing to do but silently handle the notification?
See: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#new-initialized-notification