This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Delay diagnostics to give priority to other client requests #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
suggested changes
Sep 4, 2017
src/typescript-service.ts
Outdated
| @@ -1267,7 +1267,7 @@ export class TypeScriptService { | |||
| // Ensure files needed for most operations are fetched | |||
| await this.projectManager.ensureReferencedFiles(uri).toPromise(); | |||
| this.projectManager.didOpen(uri, params.textDocument.text); | |||
| this._publishDiagnostics(uri); | |||
| setTimeout(() => this._publishDiagnostics(uri), 200); | |||
There was a problem hiding this comment.
if publishDiagnostics throws this crashes the process. I would do this:
await new Promise(resolve => setTimeout(resolve, 200))
this._publishDiagnostics(uri)There was a problem hiding this comment.
Whoops, all error handling out the window.
Cleaned up the tests after applying your suggestion, thanks for the help!
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
+ Coverage 60.03% 60.07% +0.03%
==========================================
Files 14 14
Lines 2137 2139 +2
Branches 350 350
==========================================
+ Hits 1283 1285 +2
Misses 705 705
Partials 149 149
Continue to review full report at Codecov.
|
felixfbecker
approved these changes
Sep 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove an initial delay before the language server answers a completion request (see #331)
Currently uses setTimeout, would like to know about a preferable approach?