Remove unreachable code.

dmitshur · dmitshur · commit dbc5a88071f4 · 2015-05-14T18:59:43.000-07:00
Fixes #7. Fixes Travis build.
diff --git a/diff/parse.go b/diff/parse.go
@@ -365,7 +365,6 @@ func (r *HunksReader) ReadHunk() (*Hunk, error) {
 		if r.hunk == nil {
 			// Check for presence of hunk header.
 			if !bytes.HasPrefix(line, hunkPrefix) {
-				panic("X")
 				return nil, &ParseError{r.line, r.offset, ErrNoHunkHeader}
 			}
 
@@ -436,12 +435,6 @@ func (r *HunksReader) ReadHunk() (*Hunk, error) {
 			r.hunk.Body = append(r.hunk.Body, '\n')
 		}
 	}
-
-	// Final hunk is complete. But if we never saw a hunk in this call to ReadHunk, then it means we hit EOF.
-	if r.hunk != nil {
-		return r.hunk, nil
-	}
-	return nil, io.EOF
 }
 
 const noNewlineMessage = `\ No newline at end of file`

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,6 @@ func (r HunksReader) ReadHunk() (Hunk, error) {`
`365`	`365`	`if r.hunk == nil {`
`366`	`366`	`// Check for presence of hunk header.`
`367`	`367`	`if !bytes.HasPrefix(line, hunkPrefix) {`
`368`		`- panic("X")`
`369`	`368`	`return nil, &ParseError{r.line, r.offset, ErrNoHunkHeader}`
`370`	`369`	`}`
`371`	`370`
`@@ -436,12 +435,6 @@ func (r HunksReader) ReadHunk() (Hunk, error) {`
`436`	`435`	`r.hunk.Body = append(r.hunk.Body, '\n')`
`437`	`436`	`}`
`438`	`437`	`}`
`439`		`-`
`440`		`- // Final hunk is complete. But if we never saw a hunk in this call to ReadHunk, then it means we hit EOF.`
`441`		`- if r.hunk != nil {`
`442`		`- return r.hunk, nil`
`443`		`- }`
`444`		`- return nil, io.EOF`
`445`	`438`	`}`
`446`	`439`
`447`	`440`	const noNewlineMessage = `\ No newline at end of file`