WIP

Author: Gonzalo Diaz

src/algorithm_exercises_csharp/hackerrank/warmup/MiniMaxSum.cs

@@ -2,12 +2,12 @@
 
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
-using System.Diagnostics.CodeAnalysis;
-
 public static class MiniMaxSum
 {
   public static string miniMaxSum(List<int> arr)
   {
+    ArgumentNullException.ThrowIfNull(arr);
+
     if (arr.Count == 0)
     {
       throw new ArgumentException("Parameter cannot be empty", nameof(arr));
@@ -25,6 +25,6 @@ public static string miniMaxSum(List<int> arr)
       tmax = Math.Max(tmax, value);
     }
 
-    return string.Format("{0} {1}", tsum - tmax, tsum - tmin);
+    return string.Format(System.Globalization.CultureInfo.InvariantCulture, "{0} {1}", tsum - tmax, tsum - tmin);
   }
 }

src/algorithm_exercises_csharp/hackerrank/warmup/PlusMinus.cs

@@ -3,12 +3,13 @@
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 using System.Globalization;
-using System.Diagnostics.CodeAnalysis;
 
 public static class PlusMinus
 {
   public static string plusMinus(List<int> arr)
   {
+    ArgumentNullException.ThrowIfNull(arr);
+
     int positives = 0;
     int negatives = 0;
     int zeros = 0;

src/algorithm_exercises_csharp/hackerrank/warmup/SimpleArraySum.cs

@@ -2,12 +2,12 @@
 
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
-using System.Diagnostics.CodeAnalysis;
-
 public static class SimpleArraySum
 {
   public static int simpleArraySum(int[] inputs)
   {
+    ArgumentNullException.ThrowIfNull(inputs);
+
     var total = 0;
 
     foreach (int i in inputs)

src/algorithm_exercises_csharp/hackerrank/warmup/SolveMeFirst.cs

@@ -2,8 +2,6 @@
 
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
-using System.Diagnostics.CodeAnalysis;
-
 public static class SolveMeFirst
 {
   public static int solveMeFirst(int _a, int _b)

src/algorithm_exercises_csharp/hackerrank/warmup/Staircase.cs

@@ -3,7 +3,6 @@
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 using System.Text;
-using System.Diagnostics.CodeAnalysis;
 
 public static class Staircase
 {
@@ -29,6 +28,6 @@ public static string staircase(int _n)
 
       result.Add(line.ToString());
     }
-    return String.Join("\n", result);
+    return string.Join("\n", result);
   }
 }

src/algorithm_exercises_csharp/hackerrank/warmup/TimeConversion.cs

@@ -2,19 +2,19 @@
 
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
-using System.Diagnostics.CodeAnalysis;
-
 public static class TimeConversion
 {
   public static string timeConversion(string _s)
   {
+    ArgumentNullException.ThrowIfNull(_s);
+
     string meridian = _s[^2..];
-    meridian = meridian.ToLower();
+    meridian = meridian.ToLowerInvariant();
 
     string time_str = _s[0..(_s.Length - 2)];
     List<string> time = [.. time_str.Split(":")];
 
-    int hour = Int32.Parse(time[0]);
+    int hour = Int32.Parse(time[0], System.Globalization.CultureInfo.InvariantCulture);
 
     if (hour >= 12)
     {
@@ -25,7 +25,7 @@ public static string timeConversion(string _s)
       hour += 12;
     }
 
-    time[0] = String.Format("{0:00}", hour);
-    return String.Join(":", time);
+    time[0] = string.Format(System.Globalization.CultureInfo.InvariantCulture, "{0:00}", hour);
+    return string.Join(":", time);
   }
 }