From c9bee9c642f5bc1b3efa1bd05f373e9c265c38f3 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Fri, 13 Sep 2024 21:00:55 -0300 Subject: [PATCH] [Hacker Rank]: Warmup: Plus Minus. Issues fixed: * sonarlint: C-style array should not be used cpp:S5945 * sonarlint: Replace this macro by "const", "constexpr" or an "enum". Macros should not be used to define constants cpp:S5028 --- src/lib/exercises/src/hackerrank/warmup/plus_minus.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/exercises/src/hackerrank/warmup/plus_minus.cpp b/src/lib/exercises/src/hackerrank/warmup/plus_minus.cpp index d172006..4e60fe7 100644 --- a/src/lib/exercises/src/hackerrank/warmup/plus_minus.cpp +++ b/src/lib/exercises/src/hackerrank/warmup/plus_minus.cpp @@ -8,15 +8,15 @@ #include #include -#define BUFFER_MAX_SIZE 100 +const int BUFFER_MAX_SIZE = 10; std::string format_result(double number) { - char buffer[BUFFER_MAX_SIZE]; + std::string str; + str.reserve(BUFFER_MAX_SIZE); + char *buffer = str.data(); snprintf(buffer, BUFFER_MAX_SIZE, "%0.6lf", number); - std::string formatted = buffer; - - return formatted; + return buffer; } namespace hackerrank::warmup {