Skip to content

Commit 3ebac85

Browse files
committed
fix test for cloud_watch_alarm.py
1 parent 8589ff0 commit 3ebac85

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

aws_lambda_powertools/event_handler/async_execution/routes/cloud_watch_alarm.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@ def match(self, event: dict[str, Any]) -> tuple[Callable, CloudWatchAlarmEvent]
5757
if not arn and not alarm_name:
5858
return None
5959

60+
if not self.arn:
61+
arn = None
62+
63+
if not self.alarm_name and not self.alarm_name_prefix:
64+
alarm_name = None
65+
6066
flag_arn = self.is_target_with_arn(arn=arn)
6167
flag_alarm_name = self.is_target_with_alarm_name(alarm_name=alarm_name)
6268

tests/unit/event_handler/_async_execution/_routes/test_cloud_watch_alarm.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,24 @@ def test_constructor_error(self):
2828
{
2929
"func": lambda _: None,
3030
"arn": "arn:aws:cloudwatch:us-east-1:111122223333:alarm:SuppressionDemo.Main",
31-
"alarm_name": "CompositeDemo.MainV2",
31+
"alarm_name": "CompositeDemo.Main",
3232
},
3333
),
3434
(
3535
"cloudWatchAlarmEventCompositeMetric.json",
3636
{
3737
"func": lambda _: None,
3838
"arn": "arn:aws:cloudwatch:us-east-1:111122223333:alarm:SuppressionDemo.Main",
39-
"alarm_name_prefix": "CompositeDD",
39+
"alarm_name_prefix": "CompositeD",
4040
},
4141
),
4242
(
4343
"cloudWatchAlarmEventCompositeMetric.json",
4444
{
4545
"func": lambda _: None,
4646
"arn": "arn:aws:cloudwatch:us-east-1:111122223333:alarm:SuppressionDemo.Main",
47-
"alarm_name": "CompositeDemo.MainV2",
48-
"alarm_name_prefix": "CompositeDD",
47+
"alarm_name": "CompositeDemo.Main",
48+
"alarm_name_prefix": "CompositeD",
4949
},
5050
),
5151
# cloudWatchAlarmEventCompositeMetric.json, match alarm_name, without alarm_name_prefix
@@ -87,24 +87,24 @@ def test_constructor_error(self):
8787
{
8888
"func": lambda _: None,
8989
"arn": "arn:aws:cloudwatch:eu-west-1:912397435824:alarm:test_alarm",
90-
"alarm_name": "Test alertV2",
90+
"alarm_name": "Test alert",
9191
},
9292
),
9393
(
9494
"cloudWatchAlarmEventSingleMetric.json",
9595
{
9696
"func": lambda _: None,
9797
"arn": "arn:aws:cloudwatch:eu-west-1:912397435824:alarm:test_alarm",
98-
"alarm_name_prefix": "Test-a",
98+
"alarm_name_prefix": "Test a",
9999
},
100100
),
101101
(
102102
"cloudWatchAlarmEventSingleMetric.json",
103103
{
104104
"func": lambda _: None,
105105
"arn": "arn:aws:cloudwatch:eu-west-1:912397435824:alarm:test_alarm",
106-
"alarm_name": "Test alertV2",
107-
"alarm_name_prefix": "Test-a",
106+
"alarm_name": "Test alert",
107+
"alarm_name_prefix": "Test a",
108108
},
109109
),
110110
# cloudWatchAlarmEventSingleMetric.json, match alarm_name, without alarm_name_prefix

0 commit comments

Comments
 (0)