chore: Drop PROCESS_QUERY_INFORMATION support

secDre4mer · secDre4mer · commit d07af877ef62 · 2021-08-19T15:41:50.000+02:00
PROCESS_QUERY_INFORMATION was used for compatibility reasons with
Windows XP / Server 2003. Both are no longer supported in Golang
and haven't been for a while (since Go 1.11). It should be safe
to drop this flag. PROCESS_QUERY_LIMITED_INFORMATION supports
PPL process such as LSASS, which are not queryable without this
change.
diff --git a/process/process_windows.go b/process/process_windows.go
@@ -40,7 +40,7 @@ var (
 	processorArchitecture uint
 )
 
-const processQueryInformation = windows.PROCESS_QUERY_LIMITED_INFORMATION | windows.PROCESS_QUERY_INFORMATION // WinXP doesn't know PROCESS_QUERY_LIMITED_INFORMATION
+const processQueryInformation = windows.PROCESS_QUERY_LIMITED_INFORMATION
 
 type SystemProcessInformation struct {
 	NextEntryOffset   uint64
diff --git a/v3/process/process_windows.go b/v3/process/process_windows.go
@@ -40,7 +40,7 @@ var (
 	processorArchitecture uint
 )
 
-const processQueryInformation = windows.PROCESS_QUERY_LIMITED_INFORMATION | windows.PROCESS_QUERY_INFORMATION // WinXP doesn't know PROCESS_QUERY_LIMITED_INFORMATION
+const processQueryInformation = windows.PROCESS_QUERY_LIMITED_INFORMATION
 
 type systemProcessorInformation struct {
 	ProcessorArchitecture uint16

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ var (`
`40`	`40`	`processorArchitecture uint`
`41`	`41`	`)`
`42`	`42`
`43`		`-const processQueryInformation = windows.PROCESS_QUERY_LIMITED_INFORMATION \| windows.PROCESS_QUERY_INFORMATION // WinXP doesn't know PROCESS_QUERY_LIMITED_INFORMATION`
	`43`	`+const processQueryInformation = windows.PROCESS_QUERY_LIMITED_INFORMATION`
`44`	`44`
`45`	`45`	`type SystemProcessInformation struct {`
`46`	`46`	`NextEntryOffset uint64`