From a1ba60e92d3324d212436dd45fe6d391e4bf5147 Mon Sep 17 00:00:00 2001 From: Nicholas Blumhardt Date: Tue, 22 Jun 2021 11:37:14 +1000 Subject: [PATCH 1/2] Unpin the assembly version; fixes #135 --- src/Serilog.Sinks.File/Properties/AssemblyInfo.cs | 2 -- src/Serilog.Sinks.File/Serilog.Sinks.File.csproj | 1 - 2 files changed, 3 deletions(-) diff --git a/src/Serilog.Sinks.File/Properties/AssemblyInfo.cs b/src/Serilog.Sinks.File/Properties/AssemblyInfo.cs index 0d5d620..93017cb 100644 --- a/src/Serilog.Sinks.File/Properties/AssemblyInfo.cs +++ b/src/Serilog.Sinks.File/Properties/AssemblyInfo.cs @@ -2,8 +2,6 @@ using System.Reflection; using System.Runtime.CompilerServices; -[assembly: AssemblyVersion("2.0.0.0")] - [assembly: CLSCompliant(true)] [assembly: InternalsVisibleTo("Serilog.Sinks.File.Tests, PublicKey=" + diff --git a/src/Serilog.Sinks.File/Serilog.Sinks.File.csproj b/src/Serilog.Sinks.File/Serilog.Sinks.File.csproj index b2846b9..493078d 100644 --- a/src/Serilog.Sinks.File/Serilog.Sinks.File.csproj +++ b/src/Serilog.Sinks.File/Serilog.Sinks.File.csproj @@ -16,7 +16,6 @@ Apache-2.0 https://github.com/serilog/serilog-sinks-file git - false Serilog true true From 6f4375147895abba5c72d9b6410e0c1f7e9d5f3b Mon Sep 17 00:00:00 2001 From: Nicholas Blumhardt Date: Tue, 22 Jun 2021 12:07:53 +1000 Subject: [PATCH 2/2] Remove matching test --- test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs b/test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs index d295dfc..fb9c9bf 100644 --- a/test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs +++ b/test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs @@ -3,7 +3,6 @@ using System.IO; using System.IO.Compression; using System.Linq; -using System.Reflection; using Xunit; using Serilog.Events; using Serilog.Sinks.File.Tests.Support; @@ -128,7 +127,7 @@ public void WhenRetentionCountAndTimeIsSetOldFilesAreDeletedByCount() Assert.True(System.IO.File.Exists(files[2])); }); } - + [Fact] public void WhenRetentionCountAndArchivingHookIsSetOldFilesAreCopiedAndOriginalDeleted() { @@ -261,13 +260,6 @@ public void IfTheLogFolderDoesNotExistItWillBeCreated() } } - [Fact] - public void AssemblyVersionIsFixedAt200() - { - var assembly = typeof(FileLoggerConfigurationExtensions).GetTypeInfo().Assembly; - Assert.Equal("2.0.0.0", assembly.GetName().Version.ToString(4)); - } - static void TestRollingEventSequence(params LogEvent[] events) { TestRollingEventSequence(