Merge pull request #150 from credfeto/bugfix/149-index-out-of-range-creating-event-id

nblumhardt · web-flow · commit 94066640e181 · 2019-08-22T08:25:06.000+10:00
#149 - Fixed index out of range issue with negative ids
diff --git a/src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLogger.cs b/src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLogger.cs
@@ -139,7 +139,7 @@ internal static LogEventProperty CreateEventIdProperty(EventId eventId)
 
             if (eventId.Id != 0)
             {
-                if (eventId.Id < LowEventIdValues.Length)
+                if (eventId.Id >= 0 && eventId.Id < LowEventIdValues.Length)
                     // Avoid some allocations
                     properties.Add(LowEventIdValues[eventId.Id]);
                 else

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ internal static LogEventProperty CreateEventIdProperty(EventId eventId)`
`139`	`139`
`140`	`140`	`if (eventId.Id != 0)`
`141`	`141`	`{`
`142`		`- if (eventId.Id < LowEventIdValues.Length)`
	`142`	`+ if (eventId.Id >= 0 && eventId.Id < LowEventIdValues.Length)`
`143`	`143`	`// Avoid some allocations`
`144`	`144`	`properties.Add(LowEventIdValues[eventId.Id]);`
`145`	`145`	`else`