Roll back EventId comparison change; the overridden != operator does not compare names

nblumhardt · nblumhardt · commit 7bdddecdee06 · 2024-03-18T10:15:48.000+10:00
diff --git a/src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLogger.cs b/src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLogger.cs
@@ -157,7 +157,8 @@ LogEvent PrepareWrite<TState>(LogEventLevel level, EventId eventId, TState state
             }
         }
 
-        if (eventId != default)
+        // The overridden `!=` operator on this type ignores `Name`.
+        if (eventId.Id != 0 || eventId.Name != null)
             properties["EventId"] = CreateEventIdPropertyValue(eventId);
 
         var (traceId, spanId) = Activity.Current is { } activity ?

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,8 @@ LogEvent PrepareWrite<TState>(LogEventLevel level, EventId eventId, TState state`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`160`		`- if (eventId != default)`
	`160`	+ // The overridden `!=` operator on this type ignores `Name`.
	`161`	`+ if (eventId.Id != 0 \|\| eventId.Name != null)`
`161`	`162`	`properties["EventId"] = CreateEventIdPropertyValue(eventId);`
`162`	`163`
`163`	`164`	`var (traceId, spanId) = Activity.Current is { } activity ?`