Skip to content

Commit 77c4bf3

Browse files
committed
[rb] don't use opts as hash in tests
1 parent cb8872c commit 77c4bf3

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,9 @@ def create_driver!(**opts, &block)
139139

140140
method = "create_#{driver}_driver".to_sym
141141
instance = if private_methods.include?(method)
142-
send method, opts
142+
send method, **opts
143143
else
144-
WebDriver::Driver.for(driver, opts)
144+
WebDriver::Driver.for(driver, **opts)
145145
end
146146
@create_driver_error_count -= 1 unless @create_driver_error_count.zero?
147147
if block
@@ -185,48 +185,48 @@ def check_for_previous_error
185185
raise DriverInstantiationError, msg, @create_driver_error.backtrace
186186
end
187187

188-
def create_remote_driver(opt = {})
189-
options = opt.delete(:capabilities)
190-
opt[:capabilities] = [WebDriver::Remote::Capabilities.send(browser)]
191-
opt[:capabilities] << options if options
192-
opt[:url] = ENV.fetch('WD_REMOTE_URL', remote_server.webdriver_url)
193-
opt[:http_client] ||= WebDriver::Remote::Http::Default.new
188+
def create_remote_driver(**opts)
189+
options = opts.delete(:capabilities)
190+
opts[:capabilities] = [WebDriver::Remote::Capabilities.send(browser)]
191+
opts[:capabilities] << options if options
192+
opts[:url] = ENV.fetch('WD_REMOTE_URL', remote_server.webdriver_url)
193+
opts[:http_client] ||= WebDriver::Remote::Http::Default.new
194194

195-
WebDriver::Driver.for(:remote, opt)
195+
WebDriver::Driver.for(:remote, **opts)
196196
end
197197

198-
def create_firefox_driver(opt = {})
198+
def create_firefox_driver(**opts)
199199
WebDriver::Firefox.path = ENV.fetch('FIREFOX_BINARY', nil) if ENV.key?('FIREFOX_BINARY')
200-
WebDriver::Driver.for :firefox, opt
200+
WebDriver::Driver.for :firefox, **opts
201201
end
202202

203-
def create_firefox_nightly_driver(opt = {})
203+
def create_firefox_nightly_driver(**opts)
204204
ENV['FIREFOX_BINARY'] = ENV.fetch('FIREFOX_NIGHTLY_BINARY', nil)
205-
opt[:capabilities] = [
205+
opts[:capabilities] = [
206206
WebDriver::Firefox::Options.new(debugger_address: true),
207207
WebDriver::Remote::Capabilities.firefox(web_socket_url: true)
208208
]
209-
create_firefox_driver(opt)
209+
create_firefox_driver(**opts)
210210
end
211211

212-
def create_ie_driver(opt = {})
213-
opt[:capabilities] = WebDriver::IE::Options.new(require_window_focus: true)
214-
WebDriver::Driver.for :ie, opt
212+
def create_ie_driver(**opts)
213+
opts[:capabilities] = WebDriver::IE::Options.new(require_window_focus: true)
214+
WebDriver::Driver.for :ie, **opts
215215
end
216216

217-
def create_chrome_driver(opt = {})
217+
def create_chrome_driver(**opts)
218218
WebDriver::Chrome.path = ENV.fetch('CHROME_BINARY', nil) if ENV.key?('CHROME_BINARY')
219-
WebDriver::Driver.for :chrome, opt
219+
WebDriver::Driver.for :chrome, **opts
220220
end
221221

222-
def create_safari_preview_driver(opt = {})
222+
def create_safari_preview_driver(**opts)
223223
WebDriver::Safari.technology_preview!
224-
WebDriver::Driver.for :safari, opt
224+
WebDriver::Driver.for :safari, **opts
225225
end
226226

227-
def create_edge_driver(opt = {})
227+
def create_edge_driver(**opts)
228228
WebDriver::Edge.path = ENV.fetch('EDGE_BINARY', nil) if ENV.key?('EDGE_BINARY')
229-
WebDriver::Driver.for :edge, opt
229+
WebDriver::Driver.for :edge, **opts
230230
end
231231

232232
def extract_browser_from_bazel_target_name

0 commit comments

Comments
 (0)