Skip to content

Commit 71cccff

Browse files
committed
Correctly generate test suites and all targets for java selenium tests
1 parent 54b8568 commit 71cccff

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

java/private/selenium_test.bzl

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ def selenium_test(name, test_class, size = "medium", browsers = BROWSERS.keys(),
7373
stripped_args.pop("jvm_flags", None)
7474
stripped_args.pop("tags", None)
7575

76+
all_tests = []
77+
7678
for browser in browsers:
7779
if not browser in BROWSERS:
7880
fail("Unrecognized browser: " + browser)
@@ -89,6 +91,12 @@ def selenium_test(name, test_class, size = "medium", browsers = BROWSERS.keys(),
8991
data = BROWSERS[browser]["data"] + data,
9092
**stripped_args
9193
)
94+
if browser == default_browser:
95+
native.alias(
96+
name = "%s-%s" % (name, browser),
97+
actual = test,
98+
)
99+
all_tests.append(":%s" % test)
92100

93101
if "selenium-remote" in tags:
94102
java_junit5_test(
@@ -106,6 +114,7 @@ def selenium_test(name, test_class, size = "medium", browsers = BROWSERS.keys(),
106114
],
107115
**stripped_args
108116
)
117+
all_tests.append(":%s-remote" % test)
109118

110119
# Handy way to run everything
111-
native.test_suite(name = "%s-all-browsers" % name, tests = [":%s-%s" % (name, default_browser)], tags = tags + ["manual"])
120+
native.test_suite(name = "%s-all-browsers" % name, tests = all_tests, tags = tags + ["manual"])

0 commit comments

Comments
 (0)