Skip to content

Commit 04e1dfc

Browse files
committed
[rb] run dev tools tests on Firefox
1 parent e51e2a9 commit 04e1dfc

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

rb/BUILD.bazel

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,7 @@ ruby_test(
298298
deps = [
299299
":bidi",
300300
":firefox",
301+
":devtools",
301302
":specs",
302303
],
303304
)
@@ -494,6 +495,7 @@ ruby_test(
494495
],
495496
deps = [
496497
":bidi",
498+
":devtools",
497499
":firefox",
498500
":remote",
499501
":specs",

rb/spec/integration/selenium/webdriver/bidi_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121

2222
module Selenium
2323
module WebDriver
24-
describe BiDi, exclusive: {browser: %i[firefox_nightly]} do
24+
describe BiDi, exclusive: {browser: %i[firefox firefox_nightly]} do
2525
it 'gets session status' do
2626
status = driver.bidi.session.status
27-
expect(status.ready).to be_false
27+
expect(status.ready).to eq false
2828
expect(status.message).to eq('Session already started')
2929
end
3030
end

rb/spec/integration/selenium/webdriver/devtools_spec.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
module Selenium
2323
module WebDriver
24-
describe DevTools, exclusive: {browser: %i[chrome edge firefox_nightly]} do
24+
describe DevTools, exclusive: {browser: %i[chrome edge firefox firefox_nightly]} do
2525
after { reset_driver! }
2626

2727
it 'sends commands' do
@@ -46,7 +46,7 @@ module WebDriver
4646
expect { driver.navigate.to url_for('xhtmlTest.html') }.to raise_error(RuntimeError, "This is fine!")
4747
end
4848

49-
context 'authentication', except: {browser: :firefox_nightly,
49+
context 'authentication', except: {browser: %i[firefox firefox_nightly],
5050
reason: 'Fetch.enable is not yet supported'} do
5151
let(:username) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.first }
5252
let(:password) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.last }
@@ -94,7 +94,7 @@ module WebDriver
9494
)
9595
end
9696

97-
it 'notifies about document log messages', except: {browser: :firefox_nightly,
97+
it 'notifies about document log messages', except: {browser: %i[firefox firefox_nightly],
9898
reason: 'Firefox & Chrome parse document differently'} do
9999
logs = []
100100
driver.on_log_event(:console) { |log| logs.push(log) }
@@ -108,7 +108,7 @@ module WebDriver
108108
)
109109
end
110110

111-
it 'notifies about document log messages', only: {browser: :firefox_nightly,
111+
it 'notifies about document log messages', only: {browser: %i[firefox firefox_nightly],
112112
reason: 'Firefox & Chrome parse document differently'} do
113113
logs = []
114114
driver.on_log_event(:console) { |log| logs.push(log) }
@@ -135,7 +135,7 @@ module WebDriver
135135
expect(exception.stacktrace).not_to be_empty
136136
end
137137

138-
it 'notifies about DOM mutations', except: {browser: :firefox_nightly,
138+
it 'notifies about DOM mutations', except: {browser: %i[firefox firefox_nightly],
139139
reason: 'Runtime.addBinding not yet supported'} do
140140
mutations = []
141141
driver.on_log_event(:mutation) { |mutation| mutations.push(mutation) }
@@ -151,7 +151,7 @@ module WebDriver
151151
expect(mutation.old_value).to eq('display:none;')
152152
end
153153

154-
context 'network interception', except: {browser: :firefox_nightly,
154+
context 'network interception', except: {browser: %i[firefox firefox_nightly],
155155
reason: 'Fetch.enable is not yet supported'} do
156156
it 'continues requests' do
157157
requests = []
@@ -201,7 +201,7 @@ module WebDriver
201201
end
202202
end
203203

204-
context 'script pinning' do
204+
context 'script pinning', except: {browser: %i[firefox firefox_nightly]} do
205205
before do
206206
driver.navigate.to url_for('xhtmlTest.html')
207207
end

0 commit comments

Comments
 (0)