Skip to content

Commit c4b1408

Browse files
committed
Do some refactoring
1 parent 0bb6ed6 commit c4b1408

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,15 @@ def open(self, url):
251251
try:
252252
self.driver.get(url)
253253
except Exception as e:
254-
if (
254+
if not hasattr(e, "msg") and hasattr(self.driver, "default_get"):
255+
try:
256+
self._check_browser()
257+
time.sleep(0.4)
258+
except Exception:
259+
logging.debug("Browser crashed! Will open new browser!")
260+
self.driver = self.get_new_driver()
261+
self.driver.default_get(url)
262+
elif (
255263
"ERR_CONNECTION_TIMED_OUT" in e.msg
256264
or "ERR_CONNECTION_CLOSED" in e.msg
257265
or "ERR_CONNECTION_RESET" in e.msg
@@ -1018,7 +1026,7 @@ def add_text(self, selector, text, by="css selector", timeout=None):
10181026
# Use after "\t" or Keys.TAB to cycle through elements first.
10191027
self.click_active_element()
10201028
return
1021-
element = self.wait_for_element_visible(
1029+
element = self.wait_for_element_present(
10221030
selector, by=by, timeout=timeout
10231031
)
10241032
if (
@@ -1113,7 +1121,7 @@ def send_keys(self, selector, text, by="css selector", timeout=None):
11131121
def press_keys(self, selector, text, by="css selector", timeout=None):
11141122
"""Use send_keys() to press one key at a time."""
11151123
self.wait_for_ready_state_complete()
1116-
element = self.wait_for_element_clickable(
1124+
element = self.wait_for_element_present(
11171125
selector, by=by, timeout=timeout
11181126
)
11191127
if self.demo_mode:

seleniumbase/fixtures/page_actions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1583,7 +1583,7 @@ def send_keys(
15831583
driver, selector, text, by="css selector", timeout=settings.LARGE_TIMEOUT
15841584
):
15851585
selector, by = page_utils.recalculate_selector(selector, by)
1586-
element = wait_for_element_clickable(
1586+
element = wait_for_element_present(
15871587
driver, selector, by=by, timeout=timeout
15881588
)
15891589
if not text.endswith("\n"):
@@ -1597,7 +1597,7 @@ def press_keys(
15971597
driver, selector, text, by="css selector", timeout=settings.LARGE_TIMEOUT
15981598
):
15991599
selector, by = page_utils.recalculate_selector(selector, by)
1600-
element = wait_for_element_clickable(
1600+
element = wait_for_element_present(
16011601
driver, selector, by=by, timeout=timeout
16021602
)
16031603
if not text.endswith("\n"):

0 commit comments

Comments
 (0)