Skip to content

Commit 9cf8f52

Browse files
authored
Merge pull request #2087 from seleniumbase/fix-issue-with-msedgedriver-on-linux
Fix issue with msedgedriver & Edge on Linux
2 parents f1a86b0 + cc5ce48 commit 9cf8f52

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

seleniumbase/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# seleniumbase package
2-
__version__ = "4.18.2"
2+
__version__ = "4.18.3"

seleniumbase/core/browser_launcher.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2448,6 +2448,7 @@ def get_local_driver(
24482448
edge_options.add_argument("--disable-gpu")
24492449
if IS_LINUX:
24502450
edge_options.add_argument("--disable-dev-shm-usage")
2451+
set_binary = False
24512452
if chromium_arg:
24522453
# Can be a comma-separated list of Chromium args
24532454
chromium_arg_list = chromium_arg.split(",")
@@ -2458,16 +2459,15 @@ def get_local_driver(
24582459
chromium_arg_item = "-" + chromium_arg_item
24592460
else:
24602461
chromium_arg_item = "--" + chromium_arg_item
2461-
if (
2462-
(IS_LINUX or "set-binary" in chromium_arg_item)
2463-
and not binary_location
2464-
):
2465-
br_app = "edge"
2466-
binary_loc = detect_b_ver.get_binary_location(br_app)
2467-
if os.path.exists(binary_loc):
2468-
binary_location = binary_loc
2462+
if "set-binary" in chromium_arg_item:
2463+
set_binary = True
24692464
elif len(chromium_arg_item) >= 3:
24702465
edge_options.add_argument(chromium_arg_item)
2466+
if (set_binary or IS_LINUX) and not binary_location:
2467+
br_app = "edge"
2468+
binary_loc = detect_b_ver.get_binary_location(br_app)
2469+
if os.path.exists(binary_loc):
2470+
binary_location = binary_loc
24712471
if binary_location:
24722472
edge_options.binary_location = binary_location
24732473
try:

0 commit comments

Comments
 (0)