Skip to content

Commit 5a57bf7

Browse files
authored
Merge pull request #1898 from seleniumbase/avoid-notifications-on-edge-when-possible
Avoid notifications on Edge when possible
2 parents 206c9d6 + b449fe5 commit 5a57bf7

File tree

3 files changed

+18
-10
lines changed

3 files changed

+18
-10
lines changed

examples/presenter/edge_presentation.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def test_presentation(self):
115115
self.play_tour()
116116
self.highlight('img[src*="microsoft-edge-version"]')
117117

118-
self.get_new_driver(browser="edge", disable_csp=True)
118+
self.get_new_driver(browser="edge")
119119
self.maximize_window()
120120
self.open("edge://settings/help")
121121
zoom_in = (
@@ -144,19 +144,24 @@ def test_presentation(self):
144144
self.play_tour()
145145
self.highlight('[href*="microsoft-edge/tools/webdriver"]')
146146

147-
self.get_new_driver(browser="edge", disable_csp=True)
147+
self.get_new_driver(browser="edge")
148148
self.maximize_window()
149149
self.open(
150150
"https://developer.microsoft.com/en-us/"
151151
"microsoft-edge/tools/webdriver/"
152152
)
153153
self.wait_for_element("#page-heading")
154-
self.create_tour(theme="introjs")
155-
self.add_tour_step("You need this", "#page-heading", alignment="right")
156-
self.add_tour_step("If you can", "#downloads-channel", alignment="top")
157-
self.add_tour_step("Available files", "#downloads", alignment="bottom")
158-
self.add_tour_step("More info", "#installation", alignment="top")
159-
self.play_tour()
154+
self.scroll_to("#page-heading")
155+
zoom_in = '#page-heading{zoom: 1.2;-moz-transform: scale(1.2);}'
156+
self.add_css_style(zoom_in)
157+
self.highlight("#page-heading", loops=8)
158+
self.sleep(1.2)
159+
self.highlight("#downloads-channel", loops=8)
160+
self.sleep(1.2)
161+
self.highlight("#downloads", loops=12)
162+
self.sleep(1.8)
163+
self.highlight("#installation", loops=12)
164+
self.sleep(1.8)
160165
self.quit_extra_driver()
161166

162167
self.switch_to_default_driver()

seleniumbase/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# seleniumbase package
2-
__version__ = "4.14.12"
2+
__version__ = "4.14.13"

seleniumbase/core/browser_launcher.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2253,7 +2253,10 @@ def get_local_driver(
22532253
)
22542254
if not enable_sync:
22552255
edge_options.add_argument("--disable-sync")
2256-
if guest_mode or IS_WINDOWS:
2256+
if (
2257+
(guest_mode or IS_WINDOWS or selenium4_or_newer)
2258+
and not recorder_ext and not disable_csp
2259+
):
22572260
edge_options.add_argument("--guest")
22582261
if headless2:
22592262
try:

0 commit comments

Comments
 (0)