Skip to content

Commit 48a9ab2

Browse files
committed
Merge pull request #22 from mdmintz/fix-mysql-pytest-plugin
Fix MySQL pytest plugin
2 parents c471831 + 4ef9537 commit 48a9ab2

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

integrations/docker/docker_setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
setup(
1010
name='seleniumbase',
11-
version='1.1.30',
11+
version='1.1.31',
1212
author='Michael Mintz',
1313
author_email='@mintzworld',
1414
maintainer='Michael Mintz',

seleniumbase/fixtures/base_case.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import pytest
1212
import sys
1313
import time
14+
import traceback
1415
import unittest
1516
import uuid
1617
from pyvirtualdisplay import Display
@@ -414,17 +415,23 @@ def setUp(self):
414415
self.testcase_manager.insert_testcase_data(data_payload)
415416
self.case_start_time = int(time.time() * 1000)
416417

417-
def __insert_test_result(self, state, err=None):
418+
def __insert_test_result(self, state, err):
418419
data_payload = TestcaseDataPayload()
419420
data_payload.runtime = int(time.time() * 1000) - self.case_start_time
420421
data_payload.guid = self.testcase_guid
421422
data_payload.execution_guid = self.execution_guid
422423
data_payload.state = state
423-
if err is not None:
424-
data_payload.message = err[1].__str__().split(
425-
'''-------------------- >> '''
426-
'''begin captured logging'''
427-
''' << --------------------''', 1)[0]
424+
if err:
425+
tb_string = traceback.format_exc()
426+
if "Message: " in tb_string:
427+
data_payload.message = "Message: " + tb_string.split(
428+
"Message: ")[-1]
429+
elif "Exception: " in tb_string:
430+
data_payload.message = tb_string.split("Exception: ")[-1]
431+
elif "Error: " in tb_string:
432+
data_payload.message = tb_string.split("Error: ")[-1]
433+
else:
434+
data_payload.message = "Unknown Error: See Stacktrace"
428435
self.testcase_manager.update_testcase_data(data_payload)
429436

430437
def tearDown(self):
@@ -469,9 +476,9 @@ def tearDown(self):
469476
self.display.stop()
470477
if self.with_db_reporting:
471478
if sys.exc_info()[1] is not None:
472-
self.__insert_test_result(constants.State.ERROR)
479+
self.__insert_test_result(constants.State.ERROR, True)
473480
else:
474-
self.__insert_test_result(constants.State.PASS)
481+
self.__insert_test_result(constants.State.PASS, False)
475482
runtime = int(time.time() * 1000) - self.execution_start_time
476483
self.testcase_manager.update_execution_data(
477484
self.execution_guid, runtime)
@@ -496,6 +503,6 @@ def tearDown(self):
496503
if self.with_db_reporting:
497504
self.testcase_manager = TestcaseManager(self.database_env)
498505
data_payload = TestcaseDataPayload()
499-
data_payload.guid = guid
506+
data_payload.guid = self.testcase_guid
500507
data_payload.logURL = index_file
501508
self.testcase_manager.update_testcase_log_url(data_payload)

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
setup(
88
name='seleniumbase',
9-
version='1.1.30',
9+
version='1.1.31',
1010
url='http://seleniumbase.com',
1111
author='Michael Mintz',
1212
author_email='@mintzworld',

0 commit comments

Comments
 (0)