Skip to content

declare const instead of var #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

declare const instead of var #23

merged 1 commit into from
Aug 21, 2019

Conversation

danieljuhl
Copy link
Contributor

Closes #22

@jahredhope
Copy link
Member

Thanks for the PR. The change makes sense but the tests need to be updated to have CI pass.
The snapshots automatically update if you run the test suite in update mode (-u):

$ npm run test -- -u

@danieljuhl
Copy link
Contributor Author

@jahredhope tests has been updated

mattcompiles
mattcompiles approved these changes Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@mattcompiles mattcompiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Going to merge this as a Breaking change due to it changing the generated template.

@mattcompiles mattcompiles merged commit 9476685 into seek-oss:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcompiles mattcompiles mattcompiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

declare const instead of var
3 participants
@danieljuhl @jahredhope @mattcompiles