fix(emit): Omit keys from sourcemap object if sourcemaps are enabled #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglockwood
commented
Apr 29, 2019
| 'utf-8' | ||
| ); | ||
|
|
||
| expect(declaration).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
Used an inline snapshot here because I wanted to have full control over what it was matching against. It also allowed me to add the test first, verify it failed, and then add my fix and re-run the test to verify it passes now. I could not have done that as easily if I generated the snapshots with the broken code.
|
Do I need to bump the package version as well as part of this PR, to make sure people get the fix? |
|
@greglockwood all good, we use semantic-release so CI will publish for us. By providing |
markdalgleish
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
Currently, if the
sourceMapoption forcss-loaderis set totrue, the emitted interface will contain keys from the sourcemap object, such asfile,mappings,names,sourceRootandsources, which it should not do.Main changes
keyRegexso it only matches the strings in the final map, not the sourceMaps object's keys.compilertest function to allow populating thesourceMapoption forcss-loader.