feat: Initial commit #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.nvmrc
Outdated
| @@ -0,0 +1 @@ | |||
| 10.9.0 | |||
.travis.yml
Outdated
| notifications: | ||
| email: false | ||
| node_js: | ||
| - '8' |
There was a problem hiding this comment.
If we have an .nvmrc file, we should delete this version config.
index.js
Outdated
| const generateNamedExports = cssModuleKeys => { | ||
| const namedExports = cssModuleToNamedExports(cssModuleKeys); | ||
| return `${namedExports} | ||
| `; |
There was a problem hiding this comment.
Is this new line incidental? Maybe convert it to \n to be explicit
michaeltaranto
approved these changes
Oct 18, 2018
index.js
Outdated
| const filename = this.resourcePath; | ||
| const { mode = 'emit' } = loaderUtils.getOptions(this) || {}; | ||
| if (!validModes.includes(mode)) { | ||
| throw new Error(`Invalid mode option: ${mode}`); |
There was a problem hiding this comment.
Should this error be passed to the callback instead of being thrown?
…oader into init-2
…oader into init-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.