Skip to content

Commit 2e6ec91

Browse files
Sort warnings before printing
1 parent 5c71771 commit 2e6ec91

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/TextUI/TestRunner.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
use function mt_srand;
2828
use function range;
2929
use function realpath;
30+
use function sort;
3031
use function sprintf;
3132
use function time;
3233
use PHPUnit\Framework\Exception;
@@ -571,7 +572,10 @@ public function run(TestSuite $suite, array $arguments = [], array $warnings = [
571572
$warnings[] = 'Directives printerClass and testdox are mutually exclusive';
572573
}
573574

574-
foreach (array_merge($warnings, $suite->warnings()) as $warning) {
575+
$warnings = array_merge($warnings, $suite->warnings());
576+
sort($warnings);
577+
578+
foreach ($warnings as $warning) {
575579
$this->writeMessage('Warning', $warning);
576580
}
577581

tests/end-to-end/generic/two-classes-per-file-invalid.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ PHPUnit\TextUI\Command::main();
1313
--EXPECTF--
1414
PHPUnit %s by Sebastian Bergmann and contributors.
1515

16+
Warning: Multiple test case classes per file is deprecated
17+
in %sTwoClassesInvalidTest.php
1618
Warning: Test case class not matching filename is deprecated
1719
in %sTwoClassesInvalidTest.php
1820
Class name was 'TwoClassesInvalid', expected 'TwoClassesInvalidTest'
1921
Warning: Test case class not matching filename is deprecated
2022
in %sTwoClassesInvalidTest.php
2123
Class name was 'TwoClassesInvalid2', expected 'TwoClassesInvalidTest'
22-
Warning: Multiple test case classes per file is deprecated
23-
in %sTwoClassesInvalidTest.php
2424

2525
.. 2 / 2 (100%)
2626

0 commit comments

Comments
 (0)