Skip to content

Commit 35bbce9

Browse files
Set both name and path attributes on the <file> element
1 parent 6efd9f6 commit 35bbce9

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

src/Report/Clover.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
*/
1010
namespace SebastianBergmann\CodeCoverage\Report;
1111

12+
use function basename;
1213
use function count;
1314
use function dirname;
1415
use function file_put_contents;
@@ -60,7 +61,8 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
6061
}
6162

6263
$xmlFile = $xmlDocument->createElement('file');
63-
$xmlFile->setAttribute('name', $item->pathAsString());
64+
$xmlFile->setAttribute('name', basename($item->pathAsString()));
65+
$xmlFile->setAttribute('path', $item->pathAsString());
6466

6567
$classes = $item->classesAndTraits();
6668
$coverageData = $item->lineCoverageData();

tests/_files/BankAccount-clover-line.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<coverage clover="%s" generated="%i">
33
<project timestamp="%i" name="BankAccount">
44
<metrics files="1" loc="35" ncloc="35" classes="1" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="5" elements="12" coveredelements="8"/>
5-
<file name="%s%eBankAccount.php">
5+
<file name="BankAccount.php" path="%s%eBankAccount.php">
66
<metrics loc="35" ncloc="35" classes="1" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="5" elements="12" coveredelements="8"/>
77
<class name="BankAccount" namespace="global">
88
<metrics complexity="5" methods="4" coveredmethods="3" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="5" elements="12" coveredelements="8"/>

tests/_files/BankAccount-clover-path.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<coverage clover="%s" generated="%i">
33
<project timestamp="%i" name="BankAccount">
44
<metrics files="1" loc="35" ncloc="35" classes="1" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="8" coveredstatements="5" elements="19" coveredelements="11"/>
5-
<file name="%s%eBankAccount.php">
5+
<file name="BankAccount.php" path="%s%eBankAccount.php">
66
<metrics loc="35" ncloc="35" classes="1" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="8" coveredstatements="5" elements="19" coveredelements="11"/>
77
<class name="BankAccount" namespace="global">
88
<metrics complexity="5" methods="4" coveredmethods="3" conditionals="7" coveredconditionals="3" statements="8" coveredstatements="5" elements="19" coveredelements="11"/>

tests/_files/class-with-anonymous-function-clover.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<coverage clover="%s" generated="%i">
33
<project timestamp="%i">
44
<metrics files="1" loc="20" ncloc="19" classes="1" methods="1" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="8" elements="9" coveredelements="9"/>
5-
<file name="%s%esource_with_class_and_anonymous_function.php">
5+
<file name="source_with_class_and_anonymous_function.php" path="%s%esource_with_class_and_anonymous_function.php">
66
<metrics loc="20" ncloc="19" classes="1" methods="1" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="8" elements="9" coveredelements="9"/>
77
<class name="CoveredClassWithAnonymousFunctionInStaticMethod" namespace="global">
88
<metrics complexity="1" methods="1" coveredmethods="1" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="8" elements="9" coveredelements="9"/>

tests/_files/ignored-lines-clover.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<coverage clover="%s" generated="%i">
33
<project timestamp="%i">
44
<metrics files="1" loc="43" ncloc="32" classes="0" methods="0" coveredmethods="0" conditionals="0" coveredconditionals="0" statements="1" coveredstatements="1" elements="1" coveredelements="1"/>
5-
<file name="%s%esource_with_ignore.php">
5+
<file name="source_with_ignore.php" path="%s%esource_with_ignore.php">
66
<metrics loc="43" ncloc="32" classes="0" methods="0" coveredmethods="0" conditionals="0" coveredconditionals="0" statements="1" coveredstatements="1" elements="1" coveredelements="1"/>
77
<class name="Foo" namespace="global">
88
<metrics complexity="1" methods="0" coveredmethods="0" conditionals="0" coveredconditionals="0" statements="0" coveredstatements="0" elements="0" coveredelements="0"/>

0 commit comments

Comments
 (0)