Skip to content

Commit 413ab7d

Browse files
committed
CI: run integration tests on multiple EVENT_LOOP_MANAGER and python versions
since we need to deprecate asyncore which was the default event loop manager, we need to extend the testing of some of the other so we can select a new default
1 parent 11b3ac1 commit 413ab7d

File tree

2 files changed

+23
-9
lines changed

2 files changed

+23
-9
lines changed

.github/workflows/integration-tests.yml

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,31 @@ on:
1010

1111
jobs:
1212
tests:
13-
runs-on: ubuntu-20.04
13+
name: test ${{ matrix.event_loop_manager }} (${{ matrix.python-version }})
1414
if: "!contains(github.event.pull_request.labels.*.name, 'disable-integration-tests')"
15+
runs-on: ${{ matrix.os }}
16+
strategy:
17+
fail-fast: false
18+
matrix:
19+
include:
20+
- os: ubuntu-latest
21+
python-version: "3.8"
22+
event_loop_manager: "libev"
23+
24+
- os: ubuntu-latest
25+
python-version: "3.8"
26+
event_loop_manager: "asyncio"
27+
28+
- os: ubuntu-latest
29+
python-version: "3.12"
30+
event_loop_manager: "libev"
1531
steps:
16-
- uses: actions/checkout@v2
17-
- name: Set up Python 3.8
18-
uses: actions/setup-python@v2
32+
- uses: actions/checkout@v3
33+
- name: Set up Python ${{ matrix.python-version }}
34+
uses: actions/setup-python@v4
1935
with:
20-
python-version: 3.8
21-
36+
python-version: ${{ matrix.python-version }}
2237
- name: Test with pytest
2338
run: |
39+
export EVENT_LOOP_MANAGER=${{ matrix.event_loop_manager }}
2440
./ci/run_integration_test.sh tests/integration/standard/ tests/integration/cqlengine/

ci/run_integration_test.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ ccm remove
3838

3939
# run test
4040

41-
echo "export SCYLLA_VERSION=${SCYLLA_RELEASE}"
42-
echo "PROTOCOL_VERSION=4 EVENT_LOOP_MANAGER=asyncio pytest --import-mode append tests/integration/standard/"
4341
export SCYLLA_VERSION=${SCYLLA_RELEASE}
4442
export MAPPED_SCYLLA_VERSION=3.11.4
45-
PROTOCOL_VERSION=4 EVENT_LOOP_MANAGER=libev pytest -rf --import-mode append $*
43+
PROTOCOL_VERSION=4 pytest -rf --import-mode append $*
4644

0 commit comments

Comments
 (0)