Skip to content

Commit 425c0bd

Browse files
committed
Coverage minima: report 100% coverage if min < 100
Previously, it was only reported as such for min = 100.
1 parent 1169ab6 commit 425c0bd

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/it/test_coverage_minima/validate.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ try {
1717
"""
1818
|[INFO] Statement coverage.: 100.00%
1919
|[INFO] Branch coverage....: 100.00%
20-
|[INFO] Coverage is above minimum [100.00% >= 95.00%]
20+
|[INFO] 100% Coverage !
2121
|""".stripMargin()
2222
)
2323
checkModule(logText, "module02",

src/main/java/org/scoverage/plugin/SCoverageCheckMojo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public void execute() throws MojoFailureException
175175
if ( minimumCoverage > 0.0 )
176176
{
177177
String minimumCoverageFormatted = scoverage.domain.DoubleFormat.twoFractionDigits( minimumCoverage );
178-
if ( is100( minimumCoverage ) && is100( coverage.statementCoveragePercent() ) )
178+
if ( is100( coverage.statementCoveragePercent() ) )
179179
{
180180
getLog().info( "100% Coverage !" );
181181
}
@@ -201,7 +201,7 @@ else if ( coverage.statementCoveragePercent() < minimumCoverage )
201201

202202
// Private utility methods
203203

204-
private boolean is100( Double d )
204+
private static boolean is100( Double d )
205205
{
206206
return Math.abs( 100 - d ) <= 0.00001d;
207207
}

0 commit comments

Comments
 (0)