Skip to content

Commit e286e48

Browse files
committed
Revert Cobertura DTD location change.
Commit 1afa9cc changed Cobertura DTD location from http://cobertura.sourceforge.net/xml/coverage-04.dtd to https://raw.githubusercontent.com/cobertura/cobertura/master/cobertura/src/site/htdocs/xml/coverage-04.dtd because the first resource was not accesible for some period of time. Now it works. On the other hand there are weird problems with the GitHub location (see scoverage/scoverage-maven-plugin#27 and scoverage/sbt-coveralls#80). Reverting to the previous location. It's [still used](https://github.com/cobertura/cobertura/blob/cobertura-2.1.1/cobertura/src/main/java/net/sourceforge/cobertura/reporting/xml/XMLReport.java#L66-L67) by Cobertura project.
1 parent f47fb18 commit e286e48

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

scalac-scoverage-plugin/src/main/scala/scoverage/report/CoberturaXmlWriter.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class CoberturaXmlWriter(sourceDirectories: Seq[File], outputDir: File) extends
1717

1818
def write(coverage: Coverage): Unit = {
1919
val file = new File(outputDir, "cobertura.xml")
20-
IOUtils.writeToFile(file, "<?xml version=\"1.0\"?>\n<!DOCTYPE coverage SYSTEM \"https://raw.githubusercontent.com/cobertura/cobertura/master/cobertura/src/site/htdocs/xml/coverage-04.dtd\">\n" +
20+
IOUtils.writeToFile(file, "<?xml version=\"1.0\"?>\n<!DOCTYPE coverage SYSTEM \"http://cobertura.sourceforge.net/xml/coverage-04.dtd\">\n" +
2121
new PrettyPrinter(120, 4).format(xml(coverage)))
2222
}
2323

scalac-scoverage-plugin/src/test/resources/scoverage/cobertura.sample.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<!--DOCTYPE coverage SYSTEM "https://raw.githubusercontent.com/cobertura/cobertura/master/cobertura/src/site/htdocs/xml/coverage-04.dtd"-->
2+
<!DOCTYPE coverage SYSTEM "http://cobertura.sourceforge.net/xml/coverage-04.dtd">
33

44
<coverage line-rate="0.9" branch-rate="0.75" version="1.9" timestamp="1187350905008">
55
<sources>

0 commit comments

Comments
 (0)