Skip to content

Commit 8333ee3

Browse files
committed
upgrade to scoverage 1.4.2 (dropping support for 2.11 as it is gone upstream)
1 parent 2d52519 commit 8333ee3

File tree

11 files changed

+4
-55
lines changed

11 files changed

+4
-55
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ targetCompatibility = '1.8'
4646

4747

4848
dependencies {
49-
compileOnly "org.scoverage:scalac-scoverage-plugin_2.12:1.4.1"
49+
compileOnly "org.scoverage:scalac-scoverage-plugin_2.13:1.4.2"
5050
implementation group: 'commons-io', name: 'commons-io', version: '2.6'
5151

5252
testImplementation 'junit:junit:4.12'

src/crossScalaVersionTest/java/org/scoverage/Scala211Test.java

Lines changed: 0 additions & 7 deletions
This file was deleted.

src/crossScalaVersionTest/java/org/scoverage/Scala213Test.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,5 @@
11
package org.scoverage;
22

3-
import org.junit.Ignore;
4-
5-
/**
6-
* Tests is currently ignored as support for Scala 2.13 is not available yet.
7-
*
8-
* @see <a href="https://github.com/scoverage/gradle-scoverage/issues/106">Issue #106</a>.
9-
*/
10-
@Ignore
113
public class Scala213Test extends ScalaVersionTest {
124
public Scala213Test() {
135
super("2_13");

src/crossScalaVersionTest/java/org/scoverage/ScalaCrossVersionAggregationTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,9 @@ public void checkAndAggregateAll() throws Exception {
2323
ScoveragePlugin.getAGGREGATE_NAME());
2424

2525
result.assertTaskSkipped(ScoveragePlugin.getREPORT_NAME());
26-
result.assertTaskSucceeded("2_11:" + ScoveragePlugin.getREPORT_NAME());
2726
result.assertTaskSucceeded("2_12:" + ScoveragePlugin.getREPORT_NAME());
2827
result.assertTaskSucceeded("2_13:" + ScoveragePlugin.getREPORT_NAME());
2928
result.assertTaskSucceeded(ScoveragePlugin.getCHECK_NAME());
30-
result.assertTaskSucceeded("2_11:" + ScoveragePlugin.getCHECK_NAME());
3129
result.assertTaskSucceeded("2_12:" + ScoveragePlugin.getCHECK_NAME());
3230
result.assertTaskSucceeded("2_13:" + ScoveragePlugin.getCHECK_NAME());
3331
result.assertTaskSucceeded(ScoveragePlugin.getAGGREGATE_NAME());
@@ -39,7 +37,6 @@ public void checkAndAggregateAll() throws Exception {
3937
private void assertAggregationFilesExist() {
4038

4139
Assert.assertTrue(resolve(reportDir(), "index.html").exists());
42-
Assert.assertTrue(resolve(reportDir(), "2_11/src/main/scala/org/hello/World2_11.scala.html").exists());
4340
Assert.assertTrue(resolve(reportDir(), "2_12/src/main/scala/org/hello/World2_12.scala.html").exists());
4441
Assert.assertTrue(resolve(reportDir(), "2_13/src/main/scala/org/hello/World2_13.scala.html").exists());
4542
}

src/crossScalaVersionTest/java/org/scoverage/ScalaVersionTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22

33
import org.junit.Assert;
44
import org.junit.Test;
5-
import org.junit.jupiter.api.Tag;
6-
import org.scoverage.ScoverageFunctionalTest;
7-
import org.scoverage.ScoveragePlugin;
85

96
import java.io.File;
107

src/crossScalaVersionTest/resources/projects/scala-multi-module-cross-version/2_11/build.gradle

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/crossScalaVersionTest/resources/projects/scala-multi-module-cross-version/2_11/src/main/scala/org/hello/World2_11.scala

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/crossScalaVersionTest/resources/projects/scala-multi-module-cross-version/2_11/src/test/scala/org/hello/World2_11Suite.scala

Lines changed: 0 additions & 13 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
include '2_11', '2_12', '2_13'
1+
include '2_12', '2_13'

src/main/groovy/org/scoverage/ScoverageExtension.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class ScoverageExtension {
5757
project.plugins.apply(ScalaPlugin.class)
5858

5959
scoverageVersion = project.objects.property(String)
60-
scoverageVersion.set('1.4.1')
60+
scoverageVersion.set('1.4.2')
6161

6262
scoverageScalaVersion = project.objects.property(String)
6363

src/main/groovy/org/scoverage/ScoverageWriter.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,13 @@
22

33
import org.gradle.api.logging.Logger;
44
import scala.Some;
5-
import scala.collection.JavaConverters;
6-
import scala.collection.mutable.Buffer;
75
import scoverage.Constants;
86
import scoverage.Coverage;
97
import scoverage.report.CoberturaXmlWriter;
108
import scoverage.report.ScoverageHtmlWriter;
119
import scoverage.report.ScoverageXmlWriter;
1210

1311
import java.io.File;
14-
import java.util.Arrays;
1512

1613
/**
1714
* Util for generating and saving coverage files.
@@ -76,8 +73,7 @@ public void write(File sourceDir,
7673
}
7774

7875
if (coverageOutputHTML) {
79-
Buffer<File> sources = JavaConverters.asScalaBufferConverter(Arrays.asList(sourceDir)).asScala();
80-
new ScoverageHtmlWriter(sources, reportDir, new Some<>(sourceEncoding)).write(coverage);
76+
new ScoverageHtmlWriter(new File[]{sourceDir}, reportDir, new Some<>(sourceEncoding)).write(coverage);
8177
logger.info("[scoverage] Written HTML report to " +
8278
reportDir.getAbsolutePath() +
8379
File.separator +

0 commit comments

Comments
 (0)