Add compatibility with spring's dependency management plugin

Author: eyalroth

src/functionalTest/java/org.scoverage/ScalaSingleModuleWithDepdencyManagerTest.java

@@ -0,0 +1,31 @@
+package org.scoverage;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class ScalaSingleModuleWithDepdencyManagerTest extends ScoverageFunctionalTest {
+
+    public ScalaSingleModuleWithDepdencyManagerTest() {
+        super("scala-single-module-dependency-manager");
+    }
+
+    @Test
+    public void checkScoverage() throws Exception {
+
+        AssertableBuildResult result = run("clean", ScoveragePlugin.getCHECK_NAME());
+
+        result.assertTaskSucceeded(ScoveragePlugin.getCOMPILE_NAME());
+        result.assertTaskSucceeded(ScoveragePlugin.getREPORT_NAME());
+        result.assertTaskSucceeded(ScoveragePlugin.getCHECK_NAME());
+        result.assertTaskDoesntExist(ScoveragePlugin.getAGGREGATE_NAME());
+
+        assertReportFilesExist();
+        assertCoverage(100.0);
+    }
+
+    private void assertReportFilesExist() {
+
+        Assert.assertTrue(resolve(reportDir(), "index.html").exists());
+        Assert.assertTrue(resolve(reportDir(), "src/main/scala/org/hello/World.scala.html").exists());
+    }
+}

src/functionalTest/resources/projects/scala-single-module-dependency-manager/build.gradle

@@ -0,0 +1,42 @@
+plugins {
+    id 'io.spring.dependency-management' version "1.0.4.RELEASE"
+    id 'org.scoverage'
+}
+
+repositories {
+    jcenter()
+}
+
+description = 'a single-module Scala project with dependency manager that builds successfully with 100% coverage'
+
+apply plugin: 'java'
+apply plugin: 'scala'
+
+
+dependencyManagement {
+    dependencies {
+        dependency group: 'org.scala-lang', name: 'scala-library', version: "${scalaVersionMajor}.${scalaVersionMinor}.${scalaVersionBuild}"
+    }
+}
+
+dependencies {
+    compile group: 'org.scala-lang', name: 'scala-library'
+
+    // scala compilation with the dependency management plugin needs this (otherwise compilation will fail)
+    zinc group: 'com.typesafe.zinc', name: 'zinc', version: '0.3.15'
+    zinc group: 'org.scala-lang', name: 'scala-library', version: '2.10.5'
+
+    testRuntime group: 'org.junit.vintage', name: 'junit-vintage-engine', version: junitVersion
+    testCompile group: 'org.junit.platform', name: 'junit-platform-runner', version: junitPlatformVersion
+
+    testCompile group: 'org.scalatest', name: "scalatest_${scalaVersionMajor}.${scalaVersionMinor}", version: scalatestVersion
+}
+
+test {
+    useJUnitPlatform()
+}
+
+scoverage {
+    minimumRate = 0.3
+}
+

src/functionalTest/resources/projects/scala-single-module-dependency-manager/settings.gradle

@@ -0,0 +1,9 @@
+package org.hello
+
+class World {
+
+  def foo(): String = {
+    val s = "a" + "b"
+    s
+  }
+}

src/functionalTest/resources/projects/scala-single-module-dependency-manager/src/main/scala/org/hello/World.scala

@@ -0,0 +1,13 @@
+package org.hello
+
+import org.junit.runner.RunWith
+import org.scalatest.FunSuite
+import org.scalatest.junit.JUnitRunner
+
+@RunWith(classOf[JUnitRunner])
+class WorldSuite extends FunSuite {
+
+  test("foo") {
+    new World().foo()
+  }
+}

src/functionalTest/resources/projects/scala-single-module-dependency-manager/src/test/scala/org/hello/WorldSuite.scala

@@ -57,14 +57,24 @@ class ScoveragePlugin implements Plugin<PluginAware> {
 
             project.afterEvaluate {
                 def scoverageVersion = project.extensions.scoverage.scoverageVersion.get()
-                def scalaVersion = project.extensions.scoverage.scoverageScalaVersion.get()
+                def scalaVersion = null
 
                 def scalaLibrary = project.configurations.compile.dependencies.find {
                     it.group == "org.scala-lang" && it.name == "scala-library"
                 }
 
                 if (scalaLibrary != null) {
-                    scalaVersion = scalaLibrary.version.substring(0, scalaLibrary.version.lastIndexOf("."))
+                    scalaVersion = scalaLibrary.version
+                }
+
+                if (scalaVersion == null && project.pluginManager.hasPlugin("io.spring.dependency-management")) {
+                    scalaVersion = project.dependencyManagement.compile.managedVersions["org.scala-lang:scala-library"]
+                }
+
+                if (scalaVersion == null) {
+                    scalaVersion = project.extensions.scoverage.scoverageScalaVersion.get()
+                } else {
+                    scalaVersion = scalaVersion.substring(0, scalaVersion.lastIndexOf("."))
                 }
 
                 def fullScoverageVersion = "$scalaVersion:$scoverageVersion"