Skip to content

Commit 1044b8a

Browse files
committed
Move all system prints to logger
1 parent 096d286 commit 1044b8a

File tree

3 files changed

+17
-9
lines changed

3 files changed

+17
-9
lines changed

src/main/groovy/org/scoverage/ScoverageAggregate.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class ScoverageAggregate extends DefaultTask {
3131
reportDir.get().deleteDir()
3232

3333
if (coverage.nonEmpty()) {
34-
ScoverageWriter.write(
34+
new ScoverageWriter(project.logger).write(
3535
rootDir,
3636
reportDir.get(),
3737
coverage.get(),

src/main/groovy/org/scoverage/ScoverageReport.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class ScoverageReport extends DefaultTask {
5050
Set<Object> measurements = IOUtils.invoked(measurementFiles)
5151
coverage.apply(measurements)
5252

53-
ScoverageWriter.write(
53+
new ScoverageWriter(project.logger).write(
5454
sources.get(),
5555
reportDir.get(),
5656
coverage,

src/main/groovy/org/scoverage/ScoverageWriter.java

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.scoverage;
22

3+
import org.gradle.api.logging.Logger;
34
import scoverage.Constants;
45
import scoverage.Coverage;
56
import scoverage.report.CoberturaXmlWriter;
@@ -15,6 +16,13 @@
1516
*/
1617
public class ScoverageWriter {
1718

19+
private final Logger logger;
20+
21+
public ScoverageWriter(Logger logger) {
22+
23+
this.logger = logger;
24+
}
25+
1826
/**
1927
* Generates all reports from given data.
2028
*
@@ -26,35 +34,35 @@ public class ScoverageWriter {
2634
* @param coverageOutputHTML switch for Scoverage HTML output
2735
* @param coverageDebug switch for Scoverage Debug output
2836
*/
29-
public static void write(File sourceDir,
37+
public void write(File sourceDir,
3038
File reportDir,
3139
Coverage coverage,
3240
Boolean coverageOutputCobertura,
3341
Boolean coverageOutputXML,
3442
Boolean coverageOutputHTML,
3543
Boolean coverageDebug) {
3644

37-
System.out.println("[scoverage] Generating scoverage reports...");
45+
logger.info("[scoverage] Generating scoverage reports...");
3846

3947
reportDir.mkdirs();
4048

4149
if (coverageOutputCobertura) {
4250
new CoberturaXmlWriter(sourceDir, reportDir).write(coverage);
43-
System.out.println("[scoverage] Written Cobertura XML report to " +
51+
logger.info("[scoverage] Written Cobertura XML report to " +
4452
reportDir.getAbsolutePath() +
4553
File.separator +
4654
"cobertura.xml");
4755
}
4856

4957
if (coverageOutputXML) {
5058
new ScoverageXmlWriter(sourceDir, reportDir, /* debug = */ false).write(coverage);
51-
System.out.println("[scoverage] Written XML report to " +
59+
logger.info("[scoverage] Written XML report to " +
5260
reportDir.getAbsolutePath() +
5361
File.separator +
5462
Constants.XMLReportFilename());
5563
if (coverageDebug) {
5664
new ScoverageXmlWriter(sourceDir, reportDir, /* debug = */ true).write(coverage);
57-
System.out.println("[scoverage] Written XML report with debug information to " +
65+
logger.info("[scoverage] Written XML report with debug information to " +
5866
reportDir.getAbsolutePath() +
5967
File.separator +
6068
Constants.XMLReportFilenameWithDebug());
@@ -63,12 +71,12 @@ public static void write(File sourceDir,
6371

6472
if (coverageOutputHTML) {
6573
new ScoverageHtmlWriter(sourceDir, reportDir).write(coverage);
66-
System.out.println("[scoverage] Written HTML report to " +
74+
logger.info("[scoverage] Written HTML report to " +
6775
reportDir.getAbsolutePath() +
6876
File.separator +
6977
"index.html");
7078
}
7179

72-
System.out.println("[scoverage] Coverage reports completed");
80+
logger.info("[scoverage] Coverage reports completed");
7381
}
7482
}

0 commit comments

Comments
 (0)