Skip to content

Commit 2136be3

Browse files
committed
Spinner: Remove redundant handling of disabled option on create
Ref #9151
1 parent ade17bf commit 2136be3

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

ui/widgets/spinner.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -268,11 +268,6 @@ $.widget( "ui.spinner", {
268268
this.uiSpinner.height() > 0 ) {
269269
this.uiSpinner.height( this.uiSpinner.height() );
270270
}
271-
272-
// Disable spinner if element was already disabled
273-
if ( this.options.disabled ) {
274-
this.disable();
275-
}
276271
},
277272

278273
_keydown: function( event ) {
@@ -427,12 +422,14 @@ $.widget( "ui.spinner", {
427422
}
428423

429424
this._super( key, value );
425+
},
430426

431-
if ( key === "disabled" ) {
432-
this._toggleClass( this.uiSpinner, null, "ui-state-disabled", !!value );
433-
this.element.prop( "disabled", !!value );
434-
this.buttons.button( value ? "disable" : "enable" );
435-
}
427+
_setOptionDisabled: function( value ) {
428+
this._super( value );
429+
430+
this._toggleClass( this.uiSpinner, null, "ui-state-disabled", !!value );
431+
this.element.prop( "disabled", !!value );
432+
this.buttons.button( value ? "disable" : "enable" );
436433
},
437434

438435
_setOptions: spinnerModifer( function( options ) {

0 commit comments

Comments
 (0)