Skip to content

Commit 7a2a49d

Browse files
authored
Change min sklearn version to 0.21.3 (#334)
1 parent 8571f97 commit 7a2a49d

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,27 +10,27 @@ on:
1010

1111
jobs:
1212

13-
# Checks compatibility with an old version of sklearn (0.20.3)
13+
# Checks compatibility with an old version of sklearn (0.21.3)
1414
compatibility:
1515
runs-on: ${{ matrix.os }}
1616
strategy:
1717
matrix:
1818
os: [ubuntu-latest]
19-
python-version: ['3.6', '3.7', '3.8']
19+
python-version: ['3.6', '3.7']
2020
steps:
2121
- uses: actions/checkout@v2
2222
- name: Set up Python
2323
uses: actions/setup-python@v2
2424
with:
2525
python-version: ${{ matrix.python-version }}
26-
- name: Run Tests with skggm + scikit-learn 0.20.3
26+
- name: Run Tests with skggm + scikit-learn 0.21.3
2727
env:
2828
SKGGM_VERSION: a0ed406586c4364ea3297a658f415e13b5cbdaf8
2929
run: |
3030
sudo apt-get install liblapack-dev
3131
pip install --upgrade pip pytest
3232
pip install wheel cython numpy scipy codecov pytest-cov
33-
pip install scikit-learn==0.20.3
33+
pip install scikit-learn==0.21.3
3434
pip install git+https://github.com/skggm/skggm.git@${SKGGM_VERSION}
3535
pytest test --cov
3636
bash <(curl -s https://codecov.io/bash)

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ metric-learn contains efficient Python implementations of several popular superv
2222

2323
- Python 3.6+ (the last version supporting Python 2 and Python 3.5 was
2424
`v0.5.0 <https://pypi.org/project/metric-learn/0.5.0/>`_)
25-
- numpy, scipy, scikit-learn>=0.20.3
25+
- numpy>= 1.11.0, scipy>= 0.17.0, scikit-learn>=0.21.3
2626

2727
**Optional dependencies**
2828

doc/getting_started.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ metric-learn can be installed in either of the following ways:
1919

2020
- Python 3.6+ (the last version supporting Python 2 and Python 3.5 was
2121
`v0.5.0 <https://pypi.org/project/metric-learn/0.5.0/>`_)
22-
- numpy, scipy, scikit-learn>=0.20.3
22+
- numpy>= 1.11.0, scipy>= 0.17.0, scikit-learn>=0.21.3
2323

2424
**Optional dependencies**
2525

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@
6363
],
6464
packages=['metric_learn'],
6565
install_requires=[
66-
'numpy',
67-
'scipy',
68-
'scikit-learn>=0.20.3',
66+
'numpy>= 1.11.0',
67+
'scipy>= 0.17.0',
68+
'scikit-learn>=0.21.3',
6969
],
7070
extras_require=dict(
7171
docs=['sphinx', 'shinx_rtd_theme', 'numpydoc'],

0 commit comments

Comments
 (0)