Skip to content

Commit 0649dcf

Browse files
committed
Updates test_warm_start
1 parent 06bca05 commit 0649dcf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/metric_learn_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,9 +336,9 @@ def test_warm_start(self, basis):
336336
# We used the whole same dataset, so it can led to overfitting
337337
after = class_separation(scml.transform(X), y)
338338
if basis == "lda":
339-
assert before > after + 0.05 # For lda, it's better by a margin of 0.05
339+
assert before > after # For lda, class separation improved with re-fit
340340
else:
341-
assert before < after # For triplet_diffs, it overfits
341+
assert before < after # For triplet_diffs, it got worse
342342

343343
class TestLSML(MetricTestCase):
344344
def test_iris(self):

0 commit comments

Comments
 (0)