Skip to content

Commit 01c3e9c

Browse files
author
mvargas33
committed
Fix tests
1 parent f1bae33 commit 01c3e9c

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

bench/benchmarks/iris.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
'Covariance': metric_learn.Covariance(),
88
'ITML_Supervised': metric_learn.ITML_Supervised(n_constraints=200),
99
'LFDA': metric_learn.LFDA(k=2, dim=2),
10-
'LMNN': metric_learn.LMNN(k=5, learn_rate=1e-6, verbose=False),
10+
'LMNN': metric_learn.LMNN(n_neighbors=5, learn_rate=1e-6, verbose=False),
1111
'LSML_Supervised': metric_learn.LSML_Supervised(n_constraints=200),
1212
'MLKR': metric_learn.MLKR(),
1313
'NCA': metric_learn.NCA(max_iter=700, n_components=2),

doc/supervised.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ indicates :math:`\mathbf{x}_{i}, \mathbf{x}_{j}` belong to different classes,
152152
X = iris_data['data']
153153
Y = iris_data['target']
154154

155-
lmnn = LMNN(k=5, learn_rate=1e-6)
155+
lmnn = LMNN(n_neighbors=5, learn_rate=1e-6)
156156
lmnn.fit(X, Y, verbose=False)
157157

158158
.. topic:: References:

examples/plot_metric_learning_examples.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def plot_tsne(X, y, colormap=plt.cm.Paired):
139139
#
140140

141141
# setting up LMNN
142-
lmnn = metric_learn.LMNN(k=5, learn_rate=1e-6)
142+
lmnn = metric_learn.LMNN(n_neighbors=5, learn_rate=1e-6)
143143

144144
# fit the data!
145145
lmnn.fit(X, y)

metric_learn/lmnn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ class LMNN(MahalanobisMixin, TransformerMixin):
116116
>>> iris_data = load_iris()
117117
>>> X = iris_data['data']
118118
>>> Y = iris_data['target']
119-
>>> lmnn = LMNN(k=5, learn_rate=1e-6)
119+
>>> lmnn = LMNN(n_neighbors=5, learn_rate=1e-6)
120120
>>> lmnn.fit(X, Y, verbose=False)
121121
122122
References

test/metric_learn_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ def test_bounds_parameters_invalid(bounds):
367367

368368
class TestLMNN(MetricTestCase):
369369
def test_iris(self):
370-
lmnn = LMNN(k=5, learn_rate=1e-6, verbose=False)
370+
lmnn = LMNN(n_neighbors=5, learn_rate=1e-6, verbose=False)
371371
lmnn.fit(self.iris_points, self.iris_labels)
372372

373373
csep = class_separation(lmnn.transform(self.iris_points),
@@ -384,7 +384,7 @@ def test_loss_grad_lbfgs(self):
384384
L = rng.randn(rng.randint(1, X.shape[1] + 1), X.shape[1])
385385
lmnn = LMNN()
386386

387-
k = lmnn.k
387+
k = lmnn.n_neighbors
388388
reg = lmnn.regularization
389389

390390
X, y = lmnn._prepare_inputs(X, y, dtype=float,
@@ -560,9 +560,9 @@ def _loss_grad(self, X, L, dfG, k, reg, target_neighbors, label_inds):
560560
def test_toy_ex_lmnn(X, y, loss):
561561
"""Test that the loss give the right result on a toy example"""
562562
L = np.array([[1]])
563-
lmnn = LMNN(k=1, regularization=0.5)
563+
lmnn = LMNN(n_neighbors=1, regularization=0.5)
564564

565-
k = lmnn.k
565+
k = lmnn.n_neighbors
566566
reg = lmnn.regularization
567567

568568
X, y = lmnn._prepare_inputs(X, y, dtype=float,

test/test_base_metric.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def test_lmnn(self):
4444
nndef_kwargs = {'convergence_tol': 0.01, 'k': 6}
4545
merged_kwargs = sk_repr_kwargs(def_kwargs, nndef_kwargs)
4646
self.assertEqual(
47-
remove_spaces(str(metric_learn.LMNN(convergence_tol=0.01, k=6))),
47+
remove_spaces(str(metric_learn.LMNN(convergence_tol=0.01, n_neighbors=6))),
4848
remove_spaces(f"LMNN({merged_kwargs})"))
4949

5050
def test_nca(self):

test/test_components_metric_conversion.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def test_itml_supervised(self):
4242
assert_array_almost_equal(L.T.dot(L), itml.get_mahalanobis_matrix())
4343

4444
def test_lmnn(self):
45-
lmnn = LMNN(k=5, learn_rate=1e-6, verbose=False)
45+
lmnn = LMNN(n_neighbors=5, learn_rate=1e-6, verbose=False)
4646
lmnn.fit(self.X, self.y)
4747
L = lmnn.components_
4848
assert_array_almost_equal(L.T.dot(L), lmnn.get_mahalanobis_matrix())

test/test_fit_transform.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ def test_itml_supervised(self):
5252
assert_array_almost_equal(res_1, res_2)
5353

5454
def test_lmnn(self):
55-
lmnn = LMNN(k=5, learn_rate=1e-6, verbose=False)
55+
lmnn = LMNN(n_neighbors=5, learn_rate=1e-6, verbose=False)
5656
lmnn.fit(self.X, self.y)
5757
res_1 = lmnn.transform(self.X)
5858

59-
lmnn = LMNN(k=5, learn_rate=1e-6, verbose=False)
59+
lmnn = LMNN(n_neighbors=5, learn_rate=1e-6, verbose=False)
6060
res_2 = lmnn.fit_transform(self.X, self.y)
6161

6262
assert_array_almost_equal(res_1, res_2)

0 commit comments

Comments
 (0)