Skip to content

Commit c8c6594

Browse files
committed
Merge branch 'generic-types'
This branch makes progress on a unified Types utility class for introspecting Java types. It is not yet fully complete, but it needs to be merged now so that the work is not lost when we begin the SciJava modularization.
2 parents b79f370 + 5ec1696 commit c8c6594

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+5059
-1314
lines changed

NOTICE.txt

Lines changed: 206 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,206 @@
1+
This project contains code adapted from Apache Commons Lang
2+
(https://commons.apache.org/proper/commons-lang/) version 3.4,
3+
as well as GenTyRef (https://github.com/coekie/gentyref) version 1.1.0,
4+
both of which are licensed under the Apache 2.0 license, as follows:
5+
6+
Apache License
7+
Version 2.0, January 2004
8+
http://www.apache.org/licenses/
9+
10+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
11+
12+
1. Definitions.
13+
14+
"License" shall mean the terms and conditions for use, reproduction,
15+
and distribution as defined by Sections 1 through 9 of this document.
16+
17+
"Licensor" shall mean the copyright owner or entity authorized by
18+
the copyright owner that is granting the License.
19+
20+
"Legal Entity" shall mean the union of the acting entity and all
21+
other entities that control, are controlled by, or are under common
22+
control with that entity. For the purposes of this definition,
23+
"control" means (i) the power, direct or indirect, to cause the
24+
direction or management of such entity, whether by contract or
25+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
26+
outstanding shares, or (iii) beneficial ownership of such entity.
27+
28+
"You" (or "Your") shall mean an individual or Legal Entity
29+
exercising permissions granted by this License.
30+
31+
"Source" form shall mean the preferred form for making modifications,
32+
including but not limited to software source code, documentation
33+
source, and configuration files.
34+
35+
"Object" form shall mean any form resulting from mechanical
36+
transformation or translation of a Source form, including but
37+
not limited to compiled object code, generated documentation,
38+
and conversions to other media types.
39+
40+
"Work" shall mean the work of authorship, whether in Source or
41+
Object form, made available under the License, as indicated by a
42+
copyright notice that is included in or attached to the work
43+
(an example is provided in the Appendix below).
44+
45+
"Derivative Works" shall mean any work, whether in Source or Object
46+
form, that is based on (or derived from) the Work and for which the
47+
editorial revisions, annotations, elaborations, or other modifications
48+
represent, as a whole, an original work of authorship. For the purposes
49+
of this License, Derivative Works shall not include works that remain
50+
separable from, or merely link (or bind by name) to the interfaces of,
51+
the Work and Derivative Works thereof.
52+
53+
"Contribution" shall mean any work of authorship, including
54+
the original version of the Work and any modifications or additions
55+
to that Work or Derivative Works thereof, that is intentionally
56+
submitted to Licensor for inclusion in the Work by the copyright owner
57+
or by an individual or Legal Entity authorized to submit on behalf of
58+
the copyright owner. For the purposes of this definition, "submitted"
59+
means any form of electronic, verbal, or written communication sent
60+
to the Licensor or its representatives, including but not limited to
61+
communication on electronic mailing lists, source code control systems,
62+
and issue tracking systems that are managed by, or on behalf of, the
63+
Licensor for the purpose of discussing and improving the Work, but
64+
excluding communication that is conspicuously marked or otherwise
65+
designated in writing by the copyright owner as "Not a Contribution."
66+
67+
"Contributor" shall mean Licensor and any individual or Legal Entity
68+
on behalf of whom a Contribution has been received by Licensor and
69+
subsequently incorporated within the Work.
70+
71+
2. Grant of Copyright License. Subject to the terms and conditions of
72+
this License, each Contributor hereby grants to You a perpetual,
73+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
74+
copyright license to reproduce, prepare Derivative Works of,
75+
publicly display, publicly perform, sublicense, and distribute the
76+
Work and such Derivative Works in Source or Object form.
77+
78+
3. Grant of Patent License. Subject to the terms and conditions of
79+
this License, each Contributor hereby grants to You a perpetual,
80+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
81+
(except as stated in this section) patent license to make, have made,
82+
use, offer to sell, sell, import, and otherwise transfer the Work,
83+
where such license applies only to those patent claims licensable
84+
by such Contributor that are necessarily infringed by their
85+
Contribution(s) alone or by combination of their Contribution(s)
86+
with the Work to which such Contribution(s) was submitted. If You
87+
institute patent litigation against any entity (including a
88+
cross-claim or counterclaim in a lawsuit) alleging that the Work
89+
or a Contribution incorporated within the Work constitutes direct
90+
or contributory patent infringement, then any patent licenses
91+
granted to You under this License for that Work shall terminate
92+
as of the date such litigation is filed.
93+
94+
4. Redistribution. You may reproduce and distribute copies of the
95+
Work or Derivative Works thereof in any medium, with or without
96+
modifications, and in Source or Object form, provided that You
97+
meet the following conditions:
98+
99+
(a) You must give any other recipients of the Work or
100+
Derivative Works a copy of this License; and
101+
102+
(b) You must cause any modified files to carry prominent notices
103+
stating that You changed the files; and
104+
105+
(c) You must retain, in the Source form of any Derivative Works
106+
that You distribute, all copyright, patent, trademark, and
107+
attribution notices from the Source form of the Work,
108+
excluding those notices that do not pertain to any part of
109+
the Derivative Works; and
110+
111+
(d) If the Work includes a "NOTICE" text file as part of its
112+
distribution, then any Derivative Works that You distribute must
113+
include a readable copy of the attribution notices contained
114+
within such NOTICE file, excluding those notices that do not
115+
pertain to any part of the Derivative Works, in at least one
116+
of the following places: within a NOTICE text file distributed
117+
as part of the Derivative Works; within the Source form or
118+
documentation, if provided along with the Derivative Works; or,
119+
within a display generated by the Derivative Works, if and
120+
wherever such third-party notices normally appear. The contents
121+
of the NOTICE file are for informational purposes only and
122+
do not modify the License. You may add Your own attribution
123+
notices within Derivative Works that You distribute, alongside
124+
or as an addendum to the NOTICE text from the Work, provided
125+
that such additional attribution notices cannot be construed
126+
as modifying the License.
127+
128+
You may add Your own copyright statement to Your modifications and
129+
may provide additional or different license terms and conditions
130+
for use, reproduction, or distribution of Your modifications, or
131+
for any such Derivative Works as a whole, provided Your use,
132+
reproduction, and distribution of the Work otherwise complies with
133+
the conditions stated in this License.
134+
135+
5. Submission of Contributions. Unless You explicitly state otherwise,
136+
any Contribution intentionally submitted for inclusion in the Work
137+
by You to the Licensor shall be under the terms and conditions of
138+
this License, without any additional terms or conditions.
139+
Notwithstanding the above, nothing herein shall supersede or modify
140+
the terms of any separate license agreement you may have executed
141+
with Licensor regarding such Contributions.
142+
143+
6. Trademarks. This License does not grant permission to use the trade
144+
names, trademarks, service marks, or product names of the Licensor,
145+
except as required for reasonable and customary use in describing the
146+
origin of the Work and reproducing the content of the NOTICE file.
147+
148+
7. Disclaimer of Warranty. Unless required by applicable law or
149+
agreed to in writing, Licensor provides the Work (and each
150+
Contributor provides its Contributions) on an "AS IS" BASIS,
151+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
152+
implied, including, without limitation, any warranties or conditions
153+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
154+
PARTICULAR PURPOSE. You are solely responsible for determining the
155+
appropriateness of using or redistributing the Work and assume any
156+
risks associated with Your exercise of permissions under this License.
157+
158+
8. Limitation of Liability. In no event and under no legal theory,
159+
whether in tort (including negligence), contract, or otherwise,
160+
unless required by applicable law (such as deliberate and grossly
161+
negligent acts) or agreed to in writing, shall any Contributor be
162+
liable to You for damages, including any direct, indirect, special,
163+
incidental, or consequential damages of any character arising as a
164+
result of this License or out of the use or inability to use the
165+
Work (including but not limited to damages for loss of goodwill,
166+
work stoppage, computer failure or malfunction, or any and all
167+
other commercial damages or losses), even if such Contributor
168+
has been advised of the possibility of such damages.
169+
170+
9. Accepting Warranty or Additional Liability. While redistributing
171+
the Work or Derivative Works thereof, You may choose to offer,
172+
and charge a fee for, acceptance of support, warranty, indemnity,
173+
or other liability obligations and/or rights consistent with this
174+
License. However, in accepting such obligations, You may act only
175+
on Your own behalf and on Your sole responsibility, not on behalf
176+
of any other Contributor, and only if You agree to indemnify,
177+
defend, and hold each Contributor harmless for any liability
178+
incurred by, or claims asserted against, such Contributor by reason
179+
of your accepting any such warranty or additional liability.
180+
181+
END OF TERMS AND CONDITIONS
182+
183+
APPENDIX: How to apply the Apache License to your work.
184+
185+
To apply the Apache License to your work, attach the following
186+
boilerplate notice, with the fields enclosed by brackets "[]"
187+
replaced with your own identifying information. (Don't include
188+
the brackets!) The text should be enclosed in the appropriate
189+
comment syntax for the file format. We also recommend that a
190+
file or class name and description of purpose be included on the
191+
same "printed page" as the copyright notice for easier
192+
identification within third-party archives.
193+
194+
Copyright [2012] [MOJO Codehaus]
195+
196+
Licensed under the Apache License, Version 2.0 (the "License");
197+
you may not use this file except in compliance with the License.
198+
You may obtain a copy of the License at
199+
200+
http://www.apache.org/licenses/LICENSE-2.0
201+
202+
Unless required by applicable law or agreed to in writing, software
203+
distributed under the License is distributed on an "AS IS" BASIS,
204+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
205+
See the License for the specific language governing permissions and
206+
limitations under the License.

pom.xml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</parent>
1111

1212
<artifactId>scijava-common</artifactId>
13-
<version>2.69.1-SNAPSHOT</version>
13+
<version>2.70.0-SNAPSHOT</version>
1414

1515
<name>SciJava Common</name>
1616
<description>SciJava Common is a shared library for SciJava software. It provides a plugin framework, with an extensible mechanism for service discovery, backed by its own annotation processor, so that plugins can be loaded dynamically. It is used by downstream projects in the SciJava ecosystem, such as ImageJ and SCIFIO.</description>
@@ -172,11 +172,6 @@ Konstanz, and KNIME GmbH.</license.copyrightOwners>
172172
</dependency>
173173

174174
<!-- Third-party dependencies -->
175-
<dependency>
176-
<groupId>com.googlecode.gentyref</groupId>
177-
<artifactId>gentyref</artifactId>
178-
<version>1.1.0</version>
179-
</dependency>
180175
<dependency>
181176
<groupId>org.bushe</groupId>
182177
<artifactId>eventbus</artifactId>

src/main/java/org/scijava/Context.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
import org.scijava.service.ServiceIndex;
5353
import org.scijava.util.ClassUtils;
5454
import org.scijava.util.Query;
55+
import org.scijava.util.Types;
5556

5657
/**
5758
* Top-level SciJava application context, which initializes and maintains a list
@@ -323,7 +324,7 @@ public <S extends Service> S service(final Class<S> c) {
323324
* service.
324325
*/
325326
public Service service(final String className) {
326-
final Class<?> c = ClassUtils.loadClass(className, false);
327+
final Class<?> c = Types.load(className, false);
327328
if (!Service.class.isAssignableFrom(c)) {
328329
throw new IllegalArgumentException("Not a service class: " + c.getName());
329330
}
@@ -342,7 +343,7 @@ public <S extends Service> S getService(final Class<S> c) {
342343

343344
/** Gets the service of the given class name (useful for scripts). */
344345
public Service getService(final String className) {
345-
final Class<?> c = ClassUtils.loadClass(className);
346+
final Class<?> c = Types.load(className);
346347
if (c == null) return null;
347348
if (!Service.class.isAssignableFrom(c)) return null; // not a service class
348349
@SuppressWarnings("unchecked")

src/main/java/org/scijava/Locatable.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
import java.net.URL;
3636

37-
import org.scijava.util.ClassUtils;
37+
import org.scijava.util.Types;
3838

3939
/**
4040
* An object whose location is defined by a URL string.
@@ -45,7 +45,7 @@ public interface Locatable {
4545

4646
/** Gets the URL string defining the object's location. */
4747
default String getLocation() {
48-
final URL location = ClassUtils.getLocation(getClass());
48+
final URL location = Types.location(getClass());
4949
return location == null ? null : location.toExternalForm();
5050
}
5151

src/main/java/org/scijava/command/CommandInfo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
import org.scijava.plugin.PluginInfo;
5858
import org.scijava.util.ClassUtils;
5959
import org.scijava.util.StringMaker;
60+
import org.scijava.util.Types;
6061

6162
/**
6263
* A collection of metadata about a particular {@link Command}.
@@ -502,8 +503,7 @@ private void checkFields(final Class<?> type) {
502503
private boolean isImmutable(final Class<?> type) {
503504
// NB: All eight primitive types, as well as the boxed primitive
504505
// wrapper classes, as well as strings, are immutable objects.
505-
return ClassUtils.isNumber(type) || ClassUtils.isText(type) ||
506-
ClassUtils.isBoolean(type);
506+
return Types.isNumber(type) || Types.isText(type) || Types.isBoolean(type);
507507
}
508508

509509
private Class<?> loadCommandClass() {

src/main/java/org/scijava/command/CommandModuleItem.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
import org.scijava.plugin.Attr;
4747
import org.scijava.plugin.Parameter;
4848
import org.scijava.util.ConversionUtils;
49-
import org.scijava.util.GenericUtils;
49+
import org.scijava.util.Types;
5050

5151
/**
5252
* {@link ModuleItem} implementation describing an input or output of a command.
@@ -76,16 +76,15 @@ public Parameter getParameter() {
7676

7777
@Override
7878
public Class<T> getType() {
79-
final Class<?> type =
80-
GenericUtils.getFieldClasses(field, getDelegateClass()).get(0);
79+
final Class<?> type = Types.raw(Types.fieldType(field, getDelegateClass()));
8180
@SuppressWarnings("unchecked")
8281
final Class<T> typedType = (Class<T>) type;
8382
return typedType;
8483
}
8584

8685
@Override
8786
public Type getGenericType() {
88-
return GenericUtils.getFieldType(field, getDelegateClass());
87+
return Types.fieldType(field, getDelegateClass());
8988
}
9089

9190
@Override
@@ -254,7 +253,7 @@ private T tValue(final String value) {
254253

255254
private <D> D tValue(final String value, final Class<D> type) {
256255
if (value == null || value.isEmpty()) return null;
257-
final Class<D> saneType = ConversionUtils.getNonprimitiveType(type);
256+
final Class<D> saneType = Types.box(type);
258257
return ConversionUtils.convert(value, saneType);
259258
}
260259

src/main/java/org/scijava/convert/AbstractConverter.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@
3838
import org.scijava.object.ObjectService;
3939
import org.scijava.plugin.AbstractHandlerPlugin;
4040
import org.scijava.plugin.Parameter;
41-
import org.scijava.util.ConversionUtils;
42-
import org.scijava.util.GenericUtils;
41+
import org.scijava.util.Types;
4342

4443
/**
4544
* Abstract superclass for {@link Converter} plugins. Performs appropriate
@@ -109,15 +108,15 @@ public boolean canConvert(final Object src, final Class<?> dest) {
109108
@Override
110109
public boolean canConvert(final Class<?> src, final Class<?> dest) {
111110
if (src == null) return false;
112-
final Class<?> saneSrc = ConversionUtils.getNonprimitiveType(src);
113-
final Class<?> saneDest = ConversionUtils.getNonprimitiveType(dest);
114-
return ConversionUtils.canCast(saneSrc, getInputType()) &&
115-
ConversionUtils.canCast(getOutputType(), saneDest);
111+
final Class<?> saneSrc = Types.box(src);
112+
final Class<?> saneDest = Types.box(dest);
113+
return Types.isAssignable(saneSrc, getInputType()) &&
114+
Types.isAssignable(getOutputType(), saneDest);
116115
}
117116

118117
@Override
119118
public Object convert(final Object src, final Type dest) {
120-
final Class<?> destClass = GenericUtils.getClass(dest);
119+
final Class<?> destClass = Types.raw(dest);
121120
return convert(src, destClass);
122121
}
123122

@@ -155,7 +154,7 @@ public Class<ConversionRequest> getType() {
155154
@Override
156155
@Deprecated
157156
public boolean canConvert(final Class<?> src, final Type dest) {
158-
final Class<?> destClass = GenericUtils.getClass(dest);
157+
final Class<?> destClass = Types.raw(dest);
159158
return canConvert(src, destClass);
160159
}
161160
}

0 commit comments

Comments
 (0)