Skip to content

CDATA support for XML #15603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

CDATA support for XML #15603

wants to merge 3 commits into from

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Jul 6, 2022 •
edited
Loading

Forward port scala/scala@f428cc6
Forward port scala/scala@85136e3
Forward port scala/scala@4df81aa

The biggest diff is for the CDATA support.

Fixes end of literal on windows, and start of literal includes open bracket.

The position fix is at #15635

Fixes #15574

@som-snytt
Copy link
Contributor Author

That community build failure is quite inscrutable

hi
hi
hi
Info Provided - howdy
Info Provided - howdy
[error] Failed tests:
[error] 	org.scalatest.diagrams.DirectDiagrammedAssertionsSpec
[error] 	org.scalatest.diagrams.DiagramsSpec
Info Provided - howdy
Info Provided - howdy
[warn] In the last 240 seconds, 6.901 (2.9%) were spent in GC. [Heap: 4.62GB free of 7.14GB, max 9.78GB] Consider increasing the JVM heap using `-Xmx` or try a different collector, e.g. `-XX:+UseG1GC`, for better performance.
[warn] In the last 175 seconds, 13.245 (7.6%) were spent in GC. [Heap: 4.70GB free of 8.47GB, max 9.78GB] Consider increasing the JVM heap using `-Xmx` or try a different collector, e.g. `-XX:+UseG1GC`, for better performance.

I don't see usual test output that shows "here is the bad result and here is what was expected". Scrolling didn't tell me.

I can run sbt test for scalatest but it's not obvious how to ask it to build against my local version.

For the PR, I had to publishLocal and bump the version in the sample repo.

@som-snytt som-snytt marked this pull request as ready for review July 6, 2022 18:27
@som-snytt som-snytt mentioned this pull request Jul 9, 2022
Merged
@som-snytt
Copy link
Contributor Author

Because I don't understand the possibly broken community build output, I'll go ahead and forward port those other fixes.

@som-snytt
Copy link
Contributor Author

I don't know if I can request validation of the first commit. Scala 2 validation per commit makes it obvious what incurs the failure.

@som-snytt som-snytt marked this pull request as draft July 10, 2022 02:44
som-snytt added 3 commits July 24, 2022 14:04
@som-snytt
Fix span of xml literal with CR-NL
845522e 
Simplified port of scala/scala@f428cc6
@som-snytt
Fix start position of tag
f2af157 
Caret is at open bracket.

Simplified forward port scala/scala@85136e3
@som-snytt
CDATA support
b4e5de7 
Adds `-Xxml:coalescing` to support cross-compilation until XML support
is dropped.

Forward port scala/scala@4df81aa
@som-snytt som-snytt force-pushed the issue/15574-windows-xml branch from 500deff to b4e5de7 Compare July 24, 2022 21:25
@som-snytt som-snytt changed the title Position fixes for XML CDATA support for XML Jul 24, 2022
@som-snytt som-snytt marked this pull request as ready for review July 24, 2022 22:16
@som-snytt som-snytt marked this pull request as draft August 3, 2022 10:06
@som-snytt som-snytt closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash related to XML in given
1 participant
@som-snytt