Merge pull request #8088 from dotty-staging/fix-#8064

liufengyun · web-flow · commit f43af5804132 · 2020-01-27T14:40:35.000+01:00
Fix #8064: Do not cross cast constructors
diff --git a/compiler/src/dotty/tools/dotc/transform/CrossCastAnd.scala b/compiler/src/dotty/tools/dotc/transform/CrossCastAnd.scala
@@ -22,7 +22,7 @@ class CrossCastAnd extends MiniPhase {
 
     lazy val qtype = tree.qualifier.tpe.widen
     val sym = tree.symbol
-    if (sym.is(Flags.Private) && qtype.typeSymbol != sym.owner)
+    if (sym.is(Flags.Private) && !sym.isConstructor && qtype.typeSymbol != sym.owner)
       cpy.Select(tree)(tree.qualifier.cast(AndType(qtype.baseType(sym.owner), tree.qualifier.tpe)), tree.name)
     else tree
   }
diff --git a/tests/run/i8064.scala b/tests/run/i8064.scala
@@ -0,0 +1,4 @@
+
+class Foo[A] private(x: Int) { self => def this() = this(0) }
+
+@main def Test = new Foo[String]()

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class CrossCastAnd extends MiniPhase {`
`22`	`22`
`23`	`23`	`lazy val qtype = tree.qualifier.tpe.widen`
`24`	`24`	`val sym = tree.symbol`
`25`		`- if (sym.is(Flags.Private) && qtype.typeSymbol != sym.owner)`
	`25`	`+ if (sym.is(Flags.Private) && !sym.isConstructor && qtype.typeSymbol != sym.owner)`
`26`	`26`	`cpy.Select(tree)(tree.qualifier.cast(AndType(qtype.baseType(sym.owner), tree.qualifier.tpe)), tree.name)`
`27`	`27`	`else tree`
`28`	`28`	`}`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
++
 +class Foo[A] private(x: Int) { self => def this() = this(0) }
++
 +@main def Test = new Foo[String]()